From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id E65963858D38; Sun,  5 Mar 2023 17:40:32 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E65963858D38
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1678038032;
	bh=6tfwK7vQlCI40lNNuDWJ3L2lqo+ovC6bPmjkk+uyMZ4=;
	h=From:To:Subject:Date:From;
	b=GcrE8d5fuUBTnyWLI6AFVyhjGXY0USAJqMdLEvNMt7wNG3cLISEAlqUFN6lUrWO9s
	 y+95TrR17fOQmVCoQXSDzqTqpAQoIDZzZGtLKz5BiWm88W6SzEaNp+ofHS4tsQvIVg
	 OsF+aBOtVxakXY0aWEPZx9upwKZY0QrDvYlVuo2M=
From: "tromey at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/30201] New: remove reread_symbols
Date: Sun, 05 Mar 2023 17:40:32 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: symtab
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: tromey at sourceware dot org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-30201-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D30201

            Bug ID: 30201
           Summary: remove reread_symbols
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: symtab
          Assignee: unassigned at sourceware dot org
          Reporter: tromey at sourceware dot org
  Target Milestone: ---

In

commit 9d428aae67a67087959822b0ffd81f7df96218c7
Author: Simon Marchi <simon.marchi@efficios.com>
Date:   Wed May 20 15:44:24 2020 -0400

    gdb: reset/recompute objfile section offsets in reread_symbols



Simon mentions:

    I don't really like the approach taken by reread_symbols, trying to
    reset everything manually on the objfile object, instead of, for
    example, creating a new one from scratch.  But I don't know enough yet
    to propose a better solution.

Ages ago, Jan had a patch to remove reread_symbols in favor of
doing exactly this.

This should be reimplemented.  The current approach is just bad.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=