public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug rust/30211] Crash on tab completing while debugging rust program Date: Mon, 20 Mar 2023 13:53:46 +0000 [thread overview] Message-ID: <bug-30211-4717-OfTBuEcwsR@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-30211-4717@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=30211 --- Comment #8 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Tom Tromey <tromey@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=6e7eef72164c00d6a5a7b0bce9fa01f5481f33cb commit 6e7eef72164c00d6a5a7b0bce9fa01f5481f33cb Author: Tom Tromey <tom@tromey.com> Date: Sun Mar 19 09:13:10 2023 -0600 Use rust_demangle to fix a crash PR rust/30211 points out a crash caused by a particular completion. This turns out to happen because a Rust minsym winds up in a C++-specific path in strncmp_iw_with_mode, which ultimately causes the completer to pass invalid arguments to string::append. This patch fixes the bug by reordering the language constants so that Rust comes before C++, and then using rust_demangle. This ensures that minsyms are correctly marked as "Rust", avoiding this code and thus the crash. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=20367 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30211 Reviewed-By: Andrew Burgess <aburgess@redhat.com> -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2023-03-20 13:53 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-07 19:16 [Bug rust/30211] New: " sourceware at vorpal dot se 2023-03-07 19:17 ` [Bug rust/30211] " sourceware at vorpal dot se 2023-03-18 15:22 ` tromey at sourceware dot org 2023-03-18 15:32 ` tromey at sourceware dot org 2023-03-18 18:28 ` sourceware at vorpal dot se 2023-03-18 21:43 ` tromey at sourceware dot org 2023-03-19 15:23 ` tromey at sourceware dot org 2023-03-19 15:35 ` tromey at sourceware dot org 2023-03-20 13:53 ` cvs-commit at gcc dot gnu.org [this message] 2023-03-20 13:58 ` tromey at sourceware dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-30211-4717-OfTBuEcwsR@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).