[Bug testsuite/30250] New: [gdb/testsuite] remotedir review

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30250

            Bug ID: 30250
           Summary: [gdb/testsuite] remotedir review
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

Board variable remotedir is documented as intended for remote target:
...
name       example             description
remotedir  /tmp/runtest.[pid]  Directory on the remote target in which
                               executables are downloaded and executed
...
I didn't spot anything target-specific though in the implementation, so I
wonder if it can also be used for remote host.

Anyway, first looking at the implementation:
....
    if { [board_info $dest exists remotedir] } {
        set remotedir [board_info $dest remotedir]
        set status [remote_exec $dest mkdir "-p $remotedir"]
        if { [lindex $status 0] != 0 } {
            perror "Couldn't create remote directory $remotedir on $dest"
            return ""
        }
        set destfile $remotedir/$destfile
    }
...
it looks odd to me to hardcode "/" as path separator, but perhaps that's
considered ok because it's not enabled by default.  I see something similar for
nfsdir.

Then, the implementation doesn't look complete.

That is, remote_exec and remote_download both take remotedir into account, but
not remote_upload.

So, say we have remotedir=/tmp, and we have an exec ./a.out on build/host, and 
the exec generates ./bla.txt.

A remote_download of a.out to target gives us /tmp/a.out.

Doing a remote_exec of /tmp/a.out gives us /tmp/bla.txt.

Then doing a remote_upload from host of ./bla.txt doesn't work, we need to use
./tmp/bla.txt.

I don't see any reason why remote_upload cannot do the same as remote_download.

Finally, target_compile uses this style remote_upload for host, so if we want
remote host to work with remotedir, we need to fix this.

I'd start out with a local override of remote_upload, then try to upstream the
change.

-- 
You are receiving this mail because:
You are on the CC list for the bug.