[Bug symtab/30276] [gdb/symtab] function name is _Dmain instead of "D main"

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30276

--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #2)
> (In reply to Tom de Vries from comment #1)
> > But I have no idea whether this is correct.  Maybe this needs to be handled
> > somehow in dwarf2_physname instead?
> 
> In dwarf2_physname we do:
> ...
> dwarf2_physname (name=0x364ce9b "D main", die=0x35deb80, cu=0x2bc90f0) at
> /data/vries/gdb/src/gdb/dwarf2/read.c:7097
> 7097      struct objfile *objfile = cu->per_objfile->objfile;
> (gdb) n
> 7098      const char *retval, *mangled = NULL, *canon = NULL;
> (gdb) 
> 7099      int need_copy = 1;
> (gdb) 
> 7103      if (!die_needs_namespace (die, cu))
> (gdb) 
> 7106      if (cu->lang () != language_rust)
> (gdb) 
> 7107        mangled = dw2_linkage_name (die, cu);
> (gdb) 
> 7111      gdb::unique_xmalloc_ptr<char> demangled;
> (gdb) 
> 7112      if (mangled != NULL)
> (gdb) 
> 7114          if (cu->language_defn->store_sym_names_in_linkage_form_p ())
> (gdb) 
> 7128              demangled = gdb_demangle (mangled, (DMGL_PARAMS | DMGL_ANSI
> (gdb) 
> 7131          if (demangled)
> (gdb) 
> 7135              canon = mangled;
> (gdb) 
> 7136              need_copy = 0;
> (gdb) 
> 7140      if (canon == NULL || check_physname)
> (gdb) 
> 7168        retval = canon;
> (gdb) 
> 7170      if (need_copy)
> (gdb) 
> 7173      return retval;
> (gdb) p retval
> $8 = 0x364cea2 "_Dmain"
> ...

So, what I understand happens, we try to demangle the symbol using
gdb_demangle, but that doesn't work because we're not passing the DMGL_DLANG. 
So also this works:
...
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index c910be875a3..3debc1c1848 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -7126,7 +7126,7 @@ dwarf2_physname (const char *name, struct die_info *die,
struct dwarf2_cu *cu)
             the only disadvantage remains the minimal symbol variant
             `long name(params)' does not have the proper inferior type.  */
          demangled = gdb_demangle (mangled, (DMGL_PARAMS | DMGL_ANSI
-                                             | DMGL_RET_DROP));
+                                             | DMGL_RET_DROP | DMGL_DLANG));
        }
       if (demangled)
        canon = demangled.get ();
...
But that breaks things for c++.

-- 
You are receiving this mail because:
You are on the CC list for the bug.