public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/30369] [gdb/symtab] False match issue in skip_prologue_using_linetable
Date: Sat, 22 Apr 2023 05:50:18 +0000	[thread overview]
Message-ID: <bug-30369-4717-fWM2wZ2UCJ@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30369-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30369

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a88ee931eee4ba7339c481735b9405f66161e2f6

commit a88ee931eee4ba7339c481735b9405f66161e2f6
Author: WANG Rui <r@hev.cc>
Date:   Sat Apr 22 07:50:08 2023 +0200

    gdb: Fix false match issue in skip_prologue_using_linetable

    [ Changes in v2:
      - rebase on trunk
      Changes in v3:
      - add test-case ]

    We should exclude matches to the ending PC to prevent false matches with
the
    next function, as prologue_end is located at the end PC.

      <fun1>:
        0x00: ... <-- start_pc
        0x04: ...
        0x08: ... <-- breakpoint
        0x0c: ret
      <fun2>:
        0x10: ret <-- end_pc | prologue_end of fun2

    Tested on x86_64-linux.

    Co-Authored-By: WANG Rui <r@hev.cc> (fix, tiny change [1])
    Co-Authored-By: Tom de Vries <tdevries@suse.de> (test-case)
    Approved-by: Kevin Buettner <kevinb@redhat.com>

    [1] https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html

    PR symtab/30369
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30369

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2023-04-22  5:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-18  8:32 [Bug symtab/30369] New: " vries at gcc dot gnu.org
2023-04-18  8:34 ` [Bug symtab/30369] " vries at gcc dot gnu.org
2023-04-18 10:00 ` vries at gcc dot gnu.org
2023-04-18 12:16 ` vries at gcc dot gnu.org
2023-04-22  5:50 ` cvs-commit at gcc dot gnu.org [this message]
2023-04-22  7:33 ` cvs-commit at gcc dot gnu.org
2023-04-22  7:35 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30369-4717-fWM2wZ2UCJ@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).