From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id EFB5A3858D32; Tue, 25 Apr 2023 10:52:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EFB5A3858D32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1682419968; bh=tANwJHuK8jBhHbMV76vgeUsyglJ0DRh8Sm54mY9ljPw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Jn80cgVqB88eEDWqjQUPWPj4bAlksD6FWH3uqHQF3wgW4AUh6I9JFcPzYxBnctSVD OEe7xWL+sMCpEORes4lJUNTiMnz0v+E3tdAEz6xYxYl1iwbiLBi6POBmXzpvHyfAYe kyYujLO3n3Zn6Vaqm/xRqTXbWaPdPNLtnpvccHm0= From: "vries at gcc dot gnu.org" To: gdb-prs@sourceware.org Subject: [Bug tui/30389] [gdb/tui] status line string longer than necessary Date: Tue, 25 Apr 2023 10:52:48 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: tui X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: minor X-Bugzilla-Who: vries at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_severity Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30389 Tom de Vries changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor --- Comment #1 from Tom de Vries --- Tentative patch: ... diff --git a/gdb/tui/tui-stack.c b/gdb/tui/tui-stack.c index 0a750187c26..4769a7706d1 100644 --- a/gdb/tui/tui-stack.c +++ b/gdb/tui/tui-stack.c @@ -183,10 +183,13 @@ tui_locator_window::make_status_line () const std::string string_val =3D string.release (); - if (string.size () < status_size) - string_val.append (status_size - string.size (), ' '); - else if (string.size () > status_size) - string_val.erase (status_size, string.size ()); + size_t len =3D string_val.size () + if (len < status_size) + string_val.append (status_size - len, ' '); + else if (len > status_size) + string_val.erase (status_size, len); + + gdb_assert (string_val.size () =3D=3D status_size); return string_val; } ... --=20 You are receiving this mail because: You are on the CC list for the bug.=