public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug tui/30389] [gdb/tui] status line string longer than necessary
Date: Wed, 26 Apr 2023 16:15:53 +0000	[thread overview]
Message-ID: <bug-30389-4717-NX5pJ2X2lG@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30389-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30389

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=17f091b31eb2ad8a838bf3ab21201afd2eaf1636

commit 17f091b31eb2ad8a838bf3ab21201afd2eaf1636
Author: Tom de Vries <tdevries@suse.de>
Date:   Wed Apr 26 18:15:56 2023 +0200

    [gdb/tui] Fix length of status line string

    In commit 5d10a2041eb ("gdb: add string_file::release method") this was
added:
    ...
    +  std::string string_val = string.release ();
    ...
    without updating subsequent uses of string.size (), which returns 0 after
the
    string.release () call.

    Fix this by:
    - using string_val.size () instead of string.size (), and
    - adding an assert that would have caught this regression.

    Tested on x86_64-linux.

    Reviewed-By: Simon Marchi <simon.marchi@efficios.com>
    PR tui/30389
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30389

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2023-04-26 16:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25 10:43 [Bug tui/30389] New: " vries at gcc dot gnu.org
2023-04-25 10:44 ` [Bug tui/30389] " vries at gcc dot gnu.org
2023-04-25 10:52 ` vries at gcc dot gnu.org
2023-04-25 17:56 ` simon.marchi at polymtl dot ca
2023-04-26 16:15 ` cvs-commit at gcc dot gnu.org [this message]
2023-04-26 16:19 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30389-4717-NX5pJ2X2lG@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).