[Bug tui/30389] New: [gdb/tui] status line string longer than necessary

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30389

            Bug ID: 30389
           Summary: [gdb/tui] status line string longer than necessary
           Product: gdb
           Version: 13.1
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tui
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

Consider this bit in tui_locator_window::make_status_line ():
...
  std::string string_val = string.release ();

  if (string.size () < status_size)
    string_val.append (status_size - string.size (), ' ');
  else if (string.size () > status_size)
    string_val.erase (status_size, string.size ());

  return string_val;
...

This looks like it's trying to achieve:
...
  gdb_assert (string_val.size () == status_size);
...
but that's not the case, because string.size is used instead of
string_val.size.

String.size is 0 for me.

Regression since commit 5d10a2041eb ("gdb: add string_file::release method"),
which did:
...
+  std::string string_val = string.release ();
+
   if (string.size () < status_size)
-    string.puts (n_spaces (status_size - string.size ()));
+    string_val.append (status_size - string.size (), ' ');
   else if (string.size () > status_size)
-    string.string ().erase (status_size, string.size ());
+    string_val.erase (status_size, string.size ());

-  return std::move (string.string ());
+  return string_val;
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.