From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id CAFE7385840A; Tue, 25 Apr 2023 10:43:42 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CAFE7385840A
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1682419422;
	bh=aWIvUvzlBI1yIAtYkFBkkTJ1LrIyPrsXPuc3T52Uny8=;
	h=From:To:Subject:Date:From;
	b=cLsSTA2C101TzKYJtSdjyfiCf9jQyx4SfS5qREER8vTxX38UI7UTo3XQmA092lLy3
	 tY0KLY+ElB3IxEalD1GzWSz77AuHbKMYBHeb179RTyhX2zRBwf18SIPOqIhyfjLfsX
	 Qo43kAPURgUyP96NZpuSRDoCaZ81U3hvQkFdUYEE=
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug tui/30389] New: [gdb/tui] status line string longer than
 necessary
Date: Tue, 25 Apr 2023 10:43:42 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: tui
X-Bugzilla-Version: 13.1
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-30389-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D30389

            Bug ID: 30389
           Summary: [gdb/tui] status line string longer than necessary
           Product: gdb
           Version: 13.1
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tui
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

Consider this bit in tui_locator_window::make_status_line ():
...
  std::string string_val =3D string.release ();

  if (string.size () < status_size)
    string_val.append (status_size - string.size (), ' ');
  else if (string.size () > status_size)
    string_val.erase (status_size, string.size ());

  return string_val;
...

This looks like it's trying to achieve:
...
  gdb_assert (string_val.size () =3D=3D status_size);
...
but that's not the case, because string.size is used instead of
string_val.size.

String.size is 0 for me.

Regression since commit 5d10a2041eb ("gdb: add string_file::release method"=
),
which did:
...
+  std::string string_val =3D string.release ();
+
   if (string.size () < status_size)
-    string.puts (n_spaces (status_size - string.size ()));
+    string_val.append (status_size - string.size (), ' ');
   else if (string.size () > status_size)
-    string.string ().erase (status_size, string.size ());
+    string_val.erase (status_size, string.size ());

-  return std::move (string.string ());
+  return string_val;
...

--=20
You are receiving this mail because:
You are on the CC list for the bug.=