[Bug build/30413] [gdb/build] error: storing the address of local variable ‘<anonymous>’ in ‘frame_info_ptr::frame_list.intrusive_list<frame_info_ptr>::m_back’ [-Werror=dangling-pointer=]

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30413

--- Comment #12 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=751c7c72c0105c7d55e58bba3c069c36a74c8937

commit 751c7c72c0105c7d55e58bba3c069c36a74c8937
Author: Tom de Vries <tdevries@suse.de>
Date:   Wed May 3 21:43:03 2023 +0200

    [gdb/build] Fix frame_list position in frame.c

    In commit 995a34b1772 ("Guard against frame.c destructors running before
    frame-info.c's") the following problem was addressed.

    The frame_info_ptr destructor:
    ...
      ~frame_info_ptr ()
      {
        frame_list.erase (frame_list.iterator_to (*this));
      }
    ...
    uses frame_list, which is a static member of class frame_info_ptr,
    instantiated in frame-info.c:
    ...
    intrusive_list<frame_info_ptr> frame_info_ptr::frame_list;
    ...

    Then there's a static frame_info_pointer variable named selected_frame in
    frame.c:
    ...
    static frame_info_ptr selected_frame;
    ...

    Because the destructor of selected_frame uses frame_list, its destructor
needs
    to be called before the destructor of frame_list.

    But because they're in different compilation units, the initialization
order and
    consequently destruction order is not guarantueed.

    The commit fixed this by handling the case that the destructor of
frame_list
    is called first, adding a check on is_linked ():
    ...
       ~frame_info_ptr ()
       {
    -    frame_list.erase (frame_list.iterator_to (*this));
    +    /* If this node has static storage, it may be deleted after
    +       frame_list.  Attempting to erase ourselves would then trigger
    +       internal errors, so make sure we are still linked first.  */
    +    if (is_linked ())
    +      frame_list.erase (frame_list.iterator_to (*this));
       }
    ...

    However, since then frame_list has been moved into frame.c, and
    initialization/destruction order is guarantueed inside a compilation unit.

    Revert aforementioned commit, and fix the destruction order problem by
moving
    frame_list before selected_frame.

    Reverting the commit is another way of fixing the already fixed
    Wdangling-pointer warning reported in PR build/30413, in a different way
than
    commit 9b0ccb1ebae ("Pass const frame_info_ptr reference for
    skip_[language_]trampoline").

    Approved-By: Simon Marchi <simon.marchi@efficios.com>
    Tested on x86_64-linux.
    PR build/30413
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30413

-- 
You are receiving this mail because:
You are on the CC list for the bug.