[Bug dap/30471] New: Clean up DAP breakpoint reporting

[Bug dap/30471] New: Clean up DAP breakpoint reporting

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30471

            Bug ID: 30471
           Summary: Clean up DAP breakpoint reporting
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: dap
          Assignee: unassigned at sourceware dot org
          Reporter: tromey at sourceware dot org
  Target Milestone: ---

DAP says that stop events should differentiate between:

    reason: 'step' | 'breakpoint' | 'exception' | 'pause' | 'entry' | 'goto'
        | 'function breakpoint' | 'data breakpoint' | 'instruction breakpoint'
        | string;

Currently this isn't done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30471] Clean up DAP breakpoint reporting

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30471

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
I wonder if this is important at all.

Multiple kinds of breakpoints could exist at a given location.
So, differentiating that way doesn't always make sense; and anyway
the stop event will hold the breakpoint IDs.

For this case:

    elif _expected_stop is None:
        # FIXME what is even correct here
        _expected_stop = StopKinds.EXCEPTION

... maybe what we want is bug#13587, so we can report gdb's stop
reason.  This seems fine due to that "| string" clause at the
end of the "reason" description.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30471] Clean up DAP breakpoint reporting

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30471

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
https://microsoft.github.io/debug-adapter-protocol/specification#Events_Stopped

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30471] Clean up DAP breakpoint reporting

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30471

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
See:
https://github.com/microsoft/debug-adapter-protocol/issues/566

This points out that the 'entry' reason is intended for use by
for something like "stopped due to attach".

-- 
You are receiving this mail because:
You are on the CC list for the bug.