public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug testsuite/30538] [gdb/testsuite, aarch64] FAIL: gdb.python/py-rbreak.exp: check number of returned breakpoints is 11
Date: Mon, 12 Jun 2023 10:59:56 +0000	[thread overview]
Message-ID: <bug-30538-4717-3NAHWO03mc@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30538-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30538

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9f82823f8972fbd4bba0230b27828d87f0548cbc

commit 9f82823f8972fbd4bba0230b27828d87f0548cbc
Author: Tom de Vries <tdevries@suse.de>
Date:   Mon Jun 12 13:00:09 2023 +0200

    [gdb/testsuite] Relax breakpoint count check in gdb.python/py-rbreak.exp

    With a gdb 13.2 based package on SLE-15 aarch64,  I run into:
    ...
    (gdb) PASS: gdb.python/py-rbreak.exp: nosharedlibrary
    py sl = gdb.rbreak("^[^_]",minsyms=False)^M
    Breakpoint 2 at 0x4004ac: file ../sysdeps/aarch64/crti.S, line 63.^M
      ...
    (gdb) py print(len(sl))^M
    12^M
    (gdb) FAIL: gdb.python/py-rbreak.exp: check number of returned breakpoints
is 11
    ...

    The FAIL is due to:
    - the glibc object crti.o containing debug information for function
      call_weak_fn, and
    - the test-case not expecting this.

    The debug information is there due to compiling glibc using a binutils
which
    contains commit 591cc9fbbfd ("gas/Dwarf: record functions").

    I've run into a similar issue before, see commit 3fbbcf473a5
("[gdb/testsuite]
    Fix regexp in py-rbreak.exp").

    The fix I applied there was to use a regexp "^[^_]" to filter out
    __libc_csu_fini and __libc_csu_init, but that doesn't work for
call_weak_fn.

    Fix this by:
    - reverting the regexp to "", and
    - rewriting the check to require at least 11 functions, rather than a
precise
      match.

    Tested on x86_64-linux.

    PR testsuite/30538
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30538

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  reply	other threads:[~2023-06-12 10:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-12  7:22 [Bug testsuite/30538] New: " vries at gcc dot gnu.org
2023-06-12 10:59 ` cvs-commit at gcc dot gnu.org [this message]
2023-06-12 11:07 ` [Bug testsuite/30538] " vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30538-4717-3NAHWO03mc@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).