From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 9CCAE3858D37; Fri, 23 Jun 2023 06:47:35 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9CCAE3858D37
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1687502855;
	bh=xed41s3pyjE2s+OZ0dJfFVPylYgqRpgRDvDrMw7nVko=;
	h=From:To:Subject:Date:From;
	b=Cv598+s4lJxGGIE3ijGgOu7GyQgqMWewMcvC18qYse08IY36vXduFAqCY/s7umg2/
	 CDdGM2sEpwYxW/kpB0XBUFkPaQADzwRDaxUYEvJPa7PIKIZlvuRbaTI6qkRgYIyovt
	 oiHgJyZAgmOtw5JFBp12mAPluK06NDjEBaDlh+H0=
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug tui/30580] New: [gdb/tui] !HAVE_WBORDER and border-kind ascii
 and space
Date: Fri, 23 Jun 2023 06:47:35 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: tui
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-30580-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D30580

            Bug ID: 30580
           Summary: [gdb/tui] !HAVE_WBORDER and border-kind ascii and
                    space
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tui
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

The TUI sources contain a HAVE_WBORDER ifdef:
...
$ find gdb* -type f | xargs grep HAVE_WBORDER
gdb/config.in:#undef HAVE_WBORDER
gdb/tui/tui-wingeneral.c:#ifdef HAVE_WBORDER
...

I simulated the !HAVE_WBORDER case using:
...
-#ifdef HAVE_WBORDER
+#if 0
...
and realized that border-kind ascii and space still use the acs corners, wh=
ich
looks funny.

With space border-kind:
...
=E2=94=8C                                  =E2=94=90

 [ No Source Available ]=20=20=20=20=20=20=20=20=20=20=20=20

=E2=94=94                                  =E2=94=98
...

With ascii border-kind:
...
=E2=94=8C----------------------------------=E2=94=90
|                                  |
|[ No Source Available ]           |
|                                  |
=E2=94=94----------------------------------=E2=94=98
...

With the space border-kind there's a clear style break.

With the ascii border-kind, things look funny because the top corner elemen=
ts
do not connect to the neighboring hline and vline elements, while the bottom
corner elements do connect to the neighboring vline elements, but not the h=
line
ones (at least, in my xterm).

Maybe the ascii and space border-kind values should be eliminated for the
!HAVE_WBORDER case.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=