public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "jon at beniston dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug sim/30624] New: sim: sim_close never called
Date: Sun, 09 Jul 2023 09:07:48 +0000	[thread overview]
Message-ID: <bug-30624-4717@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=30624

            Bug ID: 30624
           Summary: sim: sim_close never called
           Product: gdb
           Version: 13.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: sim
          Assignee: unassigned at sourceware dot org
          Reporter: jon at beniston dot com
                CC: vapier at gentoo dot org
  Target Milestone: ---

Since gdb 10, it appears that sim_close is not called when quitting gdb.

In gdbsim_target::close, we have:

  for (inferior *inf : all_inferiors (this))
    close_one_inferior (inf);

But it appears close_one_inferior is never called. 

It appears this is due to the passing of "this" to all_inferiors(). If that arg
is removed, then close_one_inferior is called (which results in sim_close being
called). However, not sure if that is quite the fix, in case we do actually
need to filter out some inferiors. Not familiar enough with the code to know.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

                 reply	other threads:[~2023-07-09  9:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30624-4717@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).