[Bug gdb/30630] remote.c:8352: internal-error: wait: Assertion `!async_event_handler_marked (rs->remote_async_inferior_event_token)' failed.

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30630

--- Comment #10 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Simon Marchi <simark@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=635b2dd919b8c58e164b77c396041935fca1d66a

commit 635b2dd919b8c58e164b77c396041935fca1d66a
Author: Simon Marchi <simon.marchi@efficios.com>
Date:   Tue Oct 3 22:04:01 2023 -0400

    gdb: add assertion when marking the remote async flag

    As reported in bug 30630 [1], we hit a case where the remote target's
    async flag is marked while the target is not configured (yet) to work
    async.  This should not happen.  It is caught thanks to this assert in
    remote_target::wait:

        /* Start by clearing the flag that asks for our wait method to be
called,
           we'll mark it again at the end if needed.  If the target is not in
           async mode then the async token should not be marked.  */
        if (target_is_async_p ())
          rs->clear_async_event_handler ();
        else
          gdb_assert (!rs->async_event_handler_marked ());

    This is helpful, but I think that we could have caught the problem earlier
than
    that, at the moment we marked the handler.  Catching problems earlier
    makes them easier to debug.

    [1] https://sourceware.org/bugzilla/show_bug.cgi?id=30630

    Change-Id: I7e229c74b04da82bef6a817d5a676be5cf52e833
    Approved-By: Andrew Burgess <aburgess@redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.