public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/30656] [gdb/symtab] optimized out static handled inconsistently
Date: Thu, 20 Jul 2023 06:42:37 +0000	[thread overview]
Message-ID: <bug-30656-4717-Ghudj1njRt@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30656-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30656

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Tentative fix:
...
$ git diff
diff --git a/gdb/dwarf2/abbrev.c b/gdb/dwarf2/abbrev.c
index 1ebf8f6eed5..3a429fd41b1 100644
--- a/gdb/dwarf2/abbrev.c
+++ b/gdb/dwarf2/abbrev.c
@@ -162,7 +162,6 @@ abbrev_table::read (struct dwarf2_section_info *section,
       bool has_specification_or_origin = false;
       bool has_name = false;
       bool has_linkage_name = false;
-      bool has_location = false;
       bool has_external = false;

       /* Now read in declarations.  */
@@ -217,11 +216,6 @@ abbrev_table::read (struct dwarf2_section_info *section,
              has_linkage_name = true;
              break;

-           case DW_AT_const_value:
-           case DW_AT_location:
-             has_location = true;
-             break;
-
            case DW_AT_sibling:
              if (is_csize && cur_attr.form == DW_FORM_ref4)
                sibling_offset = size;
@@ -296,9 +290,6 @@ abbrev_table::read (struct dwarf2_section_info *section,
        cur_abbrev->interesting = false;
       else if (!tag_interesting_for_index (cur_abbrev->tag))
        cur_abbrev->interesting = false;
-      else if (!has_location && !has_specification_or_origin && !has_external
-              && cur_abbrev->tag == DW_TAG_variable)
-       cur_abbrev->interesting = false;
       else
        cur_abbrev->interesting = true;

...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  reply	other threads:[~2023-07-20  6:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-20  5:15 [Bug symtab/30656] New: " vries at gcc dot gnu.org
2023-07-20  6:42 ` vries at gcc dot gnu.org [this message]
2023-07-20  6:48 ` [Bug symtab/30656] " vries at gcc dot gnu.org
2023-07-20  7:35 ` vries at gcc dot gnu.org
2023-07-20 14:43 ` vries at gcc dot gnu.org
2023-07-21  6:25 ` cvs-commit at gcc dot gnu.org
2023-07-21  6:26 ` vries at gcc dot gnu.org
2023-07-21  6:51 ` vries at gcc dot gnu.org
2023-07-21 14:14 ` vries at gcc dot gnu.org
2023-07-21 14:16 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30656-4717-Ghudj1njRt@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).