[Bug symtab/30661] [gdb/symtab] main symbol language lookup causes symtab expansion

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30661

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #2)
> Using this:
> ...
> diff --git a/gdb/dwarf2/cooked-index.c b/gdb/dwarf2/cooked-index.c
> index 25635d9b72e..0b2d35f4b86 100644
> --- a/gdb/dwarf2/cooked-index.c
> +++ b/gdb/dwarf2/cooked-index.c
> @@ -62,7 +62,7 @@ bool
>  language_requires_canonicalization (enum language lang)
>  {
>    return (lang == language_ada
> -	  || lang == language_c
> +	  || lang == language_d
>  	  || lang == language_cplus);
>  }
>  
> @@ -242,6 +242,10 @@ cooked_index_shard::add (sect_offset die_offset, enum
> dwarf_tag tag,
>       implicit "main" discovery.  */
>    if ((flags & IS_MAIN) != 0)
>      m_main = result;
> +  else if (!language_requires_canonicalization (per_cu->lang ())
> +	   && m_main == nullptr
> +	   && strcmp (name, "main") == 0)
> +    m_main = result;
>  
>    return result;
>  }
> ...
> we get the old behaviour back, without regressing on
> gdb.dlang/dlang-start-2.exp (can't run gdb.dlang/dlang-start.exp).

Hmm, on the other hand I also want this to work for c++, so I guess a different
fix is needed.

Anyway, FWIW, tested on top of trunk on x86_64-linux, no regressions.

Also, I found the source of the requirement to mark C as a language that
requires canonicalization: c_canonicalize_name.

-- 
You are receiving this mail because:
You are on the CC list for the bug.