public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug dap/30665] DAP Server: Relative paths in stacktrace response
Date: Tue, 01 Aug 2023 18:55:54 +0000	[thread overview]
Message-ID: <bug-30665-4717-MPDUnk1rre@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30665-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30665

--- Comment #11 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=65403bd0ed22f7c26f972449403c97ff5e998b04

commit 65403bd0ed22f7c26f972449403c97ff5e998b04
Author: Tom Tromey <tromey@adacore.com>
Date:   Mon Jul 24 08:48:00 2023 -0600

    Full paths in DAP stackTrace responses

    Vladimir Makaev noticed that, in some cases, a DAP stackTrace response
    would include a relative path name for the "path" component.

    This patch changes the frame decorator code to add a new DAP-specific
    decorator, and changes the DAP entry point to frame filters to use it.
    This decorator prefers the symtab's full name, and does not fall back
    to the solib's name.

    I'm not entirely happy with this patch, because if a user frame filter
    uses FrameDecorator, it may still do the wrong thing.  It would be
    better to have frame filters return symtab-like objects instead, or to
    have a separate method to return the full path to the source file.

    I also tend to think that the solib fallback behavior of
    FrameDecorator is a mistake.  If this is ever needed, it seems to me
    that it should be a separate method.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30665

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2023-08-01 18:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-22 23:49 [Bug gdb/30665] New: " vmakaev at gmail dot com
2023-07-23  0:21 ` [Bug gdb/30665] " vmakaev at gmail dot com
2023-07-23  0:42 ` [Bug dap/30665] " vmakaev at gmail dot com
2023-07-23 14:57 ` vmakaev at gmail dot com
2023-07-23 17:48 ` tromey at sourceware dot org
2023-07-23 17:48 ` tromey at sourceware dot org
2023-07-24 14:56 ` tromey at sourceware dot org
2023-07-24 15:00 ` tromey at sourceware dot org
2023-07-24 15:02 ` tromey at sourceware dot org
2023-07-24 16:26 ` tromey at sourceware dot org
2023-07-24 17:20 ` vmakaev at gmail dot com
2023-07-24 18:23 ` tromey at sourceware dot org
2023-07-25 13:50 ` tromey at sourceware dot org
2023-07-26 15:58 ` tromey at sourceware dot org
2023-08-01 18:55 ` cvs-commit at gcc dot gnu.org [this message]
2023-08-01 18:56 ` tromey at sourceware dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30665-4717-MPDUnk1rre@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).