[Bug dap/30681] New: gdb does not send "terminated" event

[Bug dap/30681] New: gdb does not send "terminated" event

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30681

            Bug ID: 30681
           Summary: gdb does not send "terminated" event
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: dap
          Assignee: unassigned at sourceware dot org
          Reporter: tromey at sourceware dot org
  Target Milestone: ---

This comes from https://sourceware.org/bugzilla/show_bug.cgi?id=30678#c1.
gdb does not send the DAP "terminated" event.
Apparently VSCode needs this to know that debugging is done.

The DAP spec seems a little unclear on this point, as it seems
to me that the exited event should have been enough...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30681] gdb does not send "terminated" event

[vmakaev at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30681

Vladimir Makaev <vmakaev at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vmakaev at gmail dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30681] gdb does not send "terminated" event

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30681

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
Created attachment 15011
  --> https://sourceware.org/bugzilla/attachment.cgi?id=15011&action=edit
patch

It isn't super clear to me exactly when this ought to be sent.
This should work for ordinary cases at least.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30681] gdb does not send "terminated" event

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30681

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30681] gdb does not send "terminated" event

[vmakaev at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30681

--- Comment #2 from Vladimir Makaev <vmakaev at gmail dot com> ---
I've tested this patch. Seems to work correctly! Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30681] gdb does not send "terminated" event

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30681

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
Thank you for this and your other testing.
It's very helpful.

https://sourceware.org/pipermail/gdb-patches/2023-July/201133.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30681] gdb does not send "terminated" event

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30681

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30681] gdb does not send "terminated" event

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30681

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://github.com/microsof
                   |                            |t/debug-adapter-protocol/is
                   |                            |sues/150

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30681] gdb does not send "terminated" event

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30681

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=21db866dc69c481cd79b4d739c2170a7ef9b98fd

commit 21db866dc69c481cd79b4d739c2170a7ef9b98fd
Author: Tom Tromey <tromey@adacore.com>
Date:   Tue Jul 25 09:16:35 2023 -0600

    Implement DAP 'terminated' event

    This implements the DAP 'terminated' event.  Vladimir Makaev noticed
    that VSCode will not report the debug session as over unless this is
    sent.

    It's not completely clear when exactly this event ought to be sent.
    Here I've done it when the inferior exits.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30681

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30681] gdb does not send "terminated" event

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30681

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.