public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug dap/30686] [gdb/dap] ERROR: eof reading json header in gdb.dap/cond-bp.exp
Date: Fri, 28 Jul 2023 12:18:59 +0000	[thread overview]
Message-ID: <bug-30686-4717-41Z7aUWrJP@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30686-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30686

--- Comment #8 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0c8a0b88d18d9c8d6cd52bd1a56d6ab88570f287

commit 0c8a0b88d18d9c8d6cd52bd1a56d6ab88570f287
Author: Tom Tromey <tromey@adacore.com>
Date:   Thu Jul 27 07:54:18 2023 -0600

    Re-acquire GIL earlier in gdbpy_parse_and_eval

    Tom de Vries filed a bug about an intermittent gdb DAP failure -- and
    coincidentally, at the same time, Alexandra Hájková sent email about a
    somewhat similar failure.

    After looking into this for a while (with no results) using ASan and
    valgrind, I found that setting PYTHONMALLOC=malloc_debug found the bug
    instantly.

    The problem is that gdbpy_parse_and_eval releases the GIL while
    calling parse_and_eval, but fails to re-acquire it before calling
    value_to_value_object.  This is easily fixed by introducing a new
    scope.

    I wonder whether the test suite should unconditionally set
    PYTHONMALLOC=malloc_debug.

    Tested-by: Tom de Vries <tdevries@suse.de>
    Reviewed-By: Tom de Vries <tdevries@suse.de>
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30686

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2023-07-28 12:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26 14:16 [Bug dap/30686] New: " vries at gcc dot gnu.org
2023-07-26 14:18 ` [Bug dap/30686] " vries at gcc dot gnu.org
2023-07-26 14:44 ` vries at gcc dot gnu.org
2023-07-26 15:02 ` vries at gcc dot gnu.org
2023-07-26 17:38 ` tromey at sourceware dot org
2023-07-26 20:29 ` tromey at sourceware dot org
2023-07-27 13:41 ` tromey at sourceware dot org
2023-07-27 13:59 ` tromey at sourceware dot org
2023-07-27 13:59 ` tromey at sourceware dot org
2023-07-28 12:18 ` cvs-commit at gcc dot gnu.org [this message]
2023-07-28 12:19 ` tromey at sourceware dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30686-4717-41Z7aUWrJP@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).