[Bug dap/30708] New: [gdb/dap] DAP support and python 3.4

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30708

            Bug ID: 30708
           Summary: [gdb/dap] DAP support and python 3.4
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: dap
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

I ran the gdb.dap tests on a system with python 3.4, and ran into a couple of
syntax error issues, which are fixed by:
...
diff --git a/gdb/python/lib/gdb/dap/breakpoint.py
b/gdb/python/lib/gdb/dap/breakpoint.py
index 27745eb..a6465e2 100644
--- a/gdb/python/lib/gdb/dap/breakpoint.py
+++ b/gdb/python/lib/gdb/dap/breakpoint.py
@@ -199,7 +199,7 @@ def _rewrite_src_breakpoint(
     condition: Optional[str] = None,
     hitCondition: Optional[str] = None,
     logMessage: Optional[str] = None,
-    **args,
+    **args
 ):
     return {
         "source": source["path"],
@@ -238,7 +238,7 @@ def _rewrite_fn_breakpoint(
     name: str,
     condition: Optional[str] = None,
     hitCondition: Optional[str] = None,
-    **args,
+    **args
 ):
     return {
         "function": name,
@@ -267,7 +267,7 @@ def _rewrite_insn_breakpoint(
     offset: Optional[int] = None,
     condition: Optional[str] = None,
     hitCondition: Optional[str] = None,
-    **args,
+    **args
 ):
     # There's no way to set an explicit address breakpoint from
     # Python, so we rely on "spec" instead.
@@ -300,7 +300,7 @@ def _catch_exception(filterId, **args):
     elif filterId == "exception":
         cmd = "-catch-exception"
     else:
-        raise Exception(f"Invalid exception filterID: {filterId}")
+        raise Exception("Invalid exception filterID: %s" % filterId)
     result = gdb.execute_mi(cmd)
     # A little lame that there's no more direct way.
     for bp in gdb.breakpoints():
@@ -323,7 +323,7 @@ def _rewrite_exception_breakpoint(
     filterId: str,
     condition: Optional[str] = None,
     # Note that exception breakpoints do not support a hit count.
-    **args,
+    **args
 ):
     return {
         "filterId": filterId,
diff --git a/gdb/python/lib/gdb/dap/evaluate.py
b/gdb/python/lib/gdb/dap/evaluate.py
index 63e8033..9622f3c 100644
--- a/gdb/python/lib/gdb/dap/evaluate.py
+++ b/gdb/python/lib/gdb/dap/evaluate.py
@@ -95,7 +95,7 @@ def eval_request(
     expression: str,
     frameId: Optional[int] = None,
     context: str = "variables",
-    **args,
+    **args
 ):
     if context in ("watch", "variables"):
         # These seem to be expression-like.
...

But then we run into the use of module typing, which is available starting
version 3.5.

Commit 510586589e7 ("Add type-checking to DAP requests") says:
...
    I've tried to make this code compatible with older versions of Python,
    but I've only been able to try it with 3.9 and 3.10.
...

Its use is extensive:
...
breakpoint.py:21:from typing import Optional, Sequence
evaluate.py:19:from typing import Optional
launch.py:19:from typing import Mapping, Optional, Sequence
locations.py:19:from typing import Optional
typecheck.py:20:import typing
...

Maybe we should just require a higher python version for dap?

-- 
You are receiving this mail because:
You are on the CC list for the bug.