public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "tromey at sourceware dot org" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug gdb/30713] New: do not catch 'const gdb_exception &' Date: Tue, 01 Aug 2023 22:39:00 +0000 [thread overview] Message-ID: <bug-30713-4717@http.sourceware.org/bugzilla/> (raw) https://sourceware.org/bugzilla/show_bug.cgi?id=30713 Bug ID: 30713 Summary: do not catch 'const gdb_exception &' Product: gdb Version: HEAD Status: NEW Severity: normal Priority: P2 Component: gdb Assignee: unassigned at sourceware dot org Reporter: tromey at sourceware dot org Target Milestone: --- Right now a fair amount of code looks like: try ... catch (const gdb_exception &) ... stuff However,this can end up swallowing a QUIT if one is not careful. I think it would be better to catch 'const gdb_exception_error &' in nearly every spot. One question is what to do with this: struct gdb_quit_bad_alloc : public gdb_exception_quit, public std::bad_alloc I don't know why it derives from the _quit form and not _error. Perhaps that's fine, though, since it would just end up returning to the top level. -- You are receiving this mail because: You are on the CC list for the bug.
next reply other threads:[~2023-08-01 22:39 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-01 22:39 tromey at sourceware dot org [this message] 2023-08-01 22:43 ` [Bug gdb/30713] " tromey at sourceware dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-30713-4717@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).