[Bug ada/30726] [gdb/ada, cc-with-dwz] FAIL: gdb.ada/arr_acc_idx_w_gap.exp: enum_rep

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30726

--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
Fixed by:
...
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index c0cc512bfa3..5b8b54331b7 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -5104,7 +5104,8 @@ remove_extra_symbols (std::vector<struct block_symbol>
&syms)
      to ask the user to disambiguate anyways.  And if we have to
      present a multiple-choice menu, it's less confusing if the list
      isn't missing some choices that were identical and yet distinct.  */
-  if (symbols_are_identical_enums (syms))
+  if (false && symbols_are_identical_enums (syms))
     syms.resize (1);
 }
...

Here in remove_extra_symbols we randomly throw away one of the two enums.

In the cc-with-dwz variant, we throw away the wrong one because the order in
which the symbols is found has changed.

If there are two symbols remaining after remove_extra_symbols,
write_var_or_type produces an ambiguous var, which then allows the ada_pop
here:
...
        |       type_prefix TICK_ENUM_REP '(' exp ')'
                        {
                          operation_up arg = ada_pop (true, $1);
                          pstate->push_new<ada_atr_enum_rep_operation>
                            ($1, std::move (arg));
                        }
...
to resolve the literal using the $1 context_type.

-- 
You are receiving this mail because:
You are on the CC list for the bug.