From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 81B523858D35; Thu,  7 Sep 2023 19:39:51 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 81B523858D35
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1694115591;
	bh=daOmJvU4S8Erh5OymiI+EMdqTRUxeKCMkhLXiquks/w=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=fH18YjiYe7VyPzO/ciVBJcD0F0tCpEC8RO//Sy1l3NMyyAAHA1n23jEUAQ9GT8f7w
	 4YvjLHychzR7Qpeot1W9FZbvwQu420Td1dPcbc+I4usG/wlV/gdxXIUODX2mWhs3Pc
	 FeWmelzFyoxewVt2eiPwgZnypTVbDHCqDY5H8iXE=
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug ada/30726] [gdb/ada] FAIL: gdb.ada/arr_acc_idx_w_gap.exp:
 enum_rep
Date: Thu, 07 Sep 2023 19:39:50 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: ada
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-30726-4717-REJoJF9hPl@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-30726-4717@http.sourceware.org/bugzilla/>
References: <bug-30726-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D30726

--- Comment #10 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot g=
nu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Def136c7fa165=
cf3ee75c37d41561be8a7bdc89bd

commit ef136c7fa165cf3ee75c37d41561be8a7bdc89bd
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu Sep 7 21:39:42 2023 +0200

    [gdb/ada] Move identical enums handling later

    When running test-case gdb.ada/arr_acc_idx_w_gap.exp with target board
    cc-with-dwz, I run into:
    ...
    (gdb) print enum_with_gaps'enum_rep(lit3)^M
    'Enum_Rep requires argument to have same type as enum^M
    (gdb) FAIL: gdb.ada/arr_acc_idx_w_gap.exp: enum_rep
    ...

    With target_board unix, we have instead:
    ...
    (gdb) print enum_with_gaps'enum_rep(lit3)^M
    $16 =3D 13^M
    (gdb) PASS: gdb.ada/arr_acc_idx_w_gap.exp: enum_rep
    ...

    Conversely, when I add this test to the test-case:
    ...
         gdb_test "print enum_with_gaps'enum_rep(lit3)" " =3D 13" \
            "enum_rep"
    +    gdb_test "print enum_subrange'enum_rep(lit3)" " =3D 13" \
    +       "other enum_rep"
    ...
    the extra test passes with target board cc-with-dwz, but fails with tar=
get
    board unix.

    The problem is here in remove_extra_symbols:
    ...
      if (symbols_are_identical_enums (syms))
        syms.resize (1);
    ...
    where one of the two identical enums is picked before the enum_rep hand=
ling
    can resolve lit3 to one of the two.

    Fix this by moving the code to ada_resolve_variable.

    Tested on x86_64-linux.

    Approved-By: Tom Tromey <tom@tromey.com>

    PR ada/30726
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30726

--=20
You are receiving this mail because:
You are on the CC list for the bug.=