public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "tromey at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/30728] [gdb/symtab, cc-with-dwz] FAIL: gdb.cp/breakpoint-locs.exp: break N1::C1::baz
Date: Fri, 09 Feb 2024 19:48:27 +0000	[thread overview]
Message-ID: <bug-30728-4717-Hxojh75rQ5@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30728-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30728

--- Comment #17 from Tom Tromey <tromey at sourceware dot org> ---
(In reply to Tom Tromey from comment #16)
> I wonder if gdb-index and debug-names correctly attribute these
> symbols to the including CU.  If not then we'll see the bug there as well.

I forgot to mention -- if there is a DIE in the index that
comes from a partial unit, the .debug_names writer must attribute
that DIE to some other full CU.  This has to be done because
with .debug_names, gdb won't scan the DIE tree and so won't
know about imports.  However, it's also not really possible to
read a PU in isolation -- only when reading a full CU.

What I'd propose is having the .debug_names entry written
as referring to the DIE in the PU, but emit the CU as the
"canonical" includer... except when the DIE is an inline
function, in which case all CUs must be listed.

This would have also be documented as a gdb extension, because
DWARF seems to ignore this issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2024-02-09 19:48 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-06 15:50 [Bug symtab/30728] New: " vries at gcc dot gnu.org
2023-08-06 16:16 ` [Bug symtab/30728] " vries at gcc dot gnu.org
2023-08-06 16:31 ` vries at gcc dot gnu.org
2023-08-06 18:15 ` vries at gcc dot gnu.org
2023-08-06 22:00 ` vries at gcc dot gnu.org
2023-08-07 10:23 ` vries at gcc dot gnu.org
2023-08-07 10:44 ` vries at gcc dot gnu.org
2023-08-07 15:14 ` vries at gcc dot gnu.org
2023-08-07 16:35 ` tromey at sourceware dot org
2023-08-08 23:32 ` vries at gcc dot gnu.org
2023-08-09 15:31 ` vries at gcc dot gnu.org
2023-08-10  8:49 ` vries at gcc dot gnu.org
2023-08-25 15:56 ` vries at gcc dot gnu.org
2023-10-02 12:55 ` vries at gcc dot gnu.org
2023-11-29 15:08 ` jamborm at gcc dot gnu.org
2024-01-15  0:47 ` tromey at sourceware dot org
2024-01-15  1:34 ` tromey at sourceware dot org
2024-01-15  1:54 ` tromey at sourceware dot org
2024-02-09 19:48 ` tromey at sourceware dot org [this message]
2024-02-16  2:42 ` tromey at sourceware dot org
2024-05-06 13:57 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30728-4717-Hxojh75rQ5@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).