[Bug symtab/30728] [gdb/symtab, cc-with-dwz] FAIL: gdb.cp/breakpoint-locs.exp: break N1::C1::baz

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30728

--- Comment #21 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom Tromey from comment #16)
> I wonder if gdb-index and debug-names correctly attribute these
> symbols to the including CU.  If not then we'll see the bug there as well.

Good point.

FWIW, the approach of adding DW_TAG_inlined_subroutine entries to the index
(I'm currently rebasing that series) seems to work.

With .gdb_index, we get:
...
[721] N1::C1::baz:
        2 [global, function]
        1 [global, other]
        2 [global, other]
...
and with .debug_names:
...
[  5] _ZN2N12C13bazEv:
        <4> DW_TAG_subprogram DW_IDX_compile_unit=1 DW_IDX_die_offset=<0x31>
DW_IDX_GNU_language=33 DW_IDX_GNU_linkage_name=1
        <5> DW_TAG_inlined_subroutine DW_IDX_compile_unit=1
DW_IDX_die_offset=<0xac> DW_IDX_GNU_language=33 DW_IDX_GNU_linkage_name=1
        <5> DW_TAG_inlined_subroutine DW_IDX_compile_unit=2
DW_IDX_die_offset=<0x13d> DW_IDX_GNU_language=33 DW_IDX_GNU_linkage_name=1
[  9] baz:
        <6> DW_TAG_subprogram DW_IDX_compile_unit=1 DW_IDX_die_offset=<0x31>
DW_IDX_GNU_language=33 DW_IDX_parent=1
        <7> DW_TAG_inlined_subroutine DW_IDX_compile_unit=1
DW_IDX_die_offset=<0xac> DW_IDX_GNU_language=33 DW_IDX_parent=1
        <7> DW_TAG_inlined_subroutine DW_IDX_compile_unit=2
DW_IDX_die_offset=<0x13d> DW_IDX_GNU_language=33 DW_IDX_parent=1
...
and in both cases, doing "break N1::C1::baz" results in two breakpoint
locations.

For the .gdb_index case, the "other" might be need to be "function" instead,
but regardless it seems to work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.