From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 78EC23857359; Thu, 10 Aug 2023 19:16:52 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 78EC23857359
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1691695012;
	bh=rKeEVslKPT7qXKT/bV68lqv8L1P+OD5mv4P7F/hsrzw=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=ordogzqWptthxXRUZdQibIGK+HzB+FWJ5HOJp+3QNebbHK7EPY87yNwFpzW8PB7GO
	 pujkZy8v3OhIuS4hZD/Q4I9yfU2V3sHIHNUlEHBCpQN1SeacBgun2fYu5V/37l1B+3
	 FAzVPehhq2RsmoL8XYGP/3uXB/DCc/Kxr6q8XDHo=
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/30739] [gdb/symtab] wrong parent for cooked index entry
Date: Thu, 10 Aug 2023 19:16:51 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: symtab
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-30739-4717-ylggrrhgI8@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-30739-4717@http.sourceware.org/bugzilla/>
References: <bug-30739-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D30739

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gn=
u.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D8f258a6c9794=
20c33845f60575e7ed025e6dcd9d

commit 8f258a6c979420c33845f60575e7ed025e6dcd9d
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu Aug 10 21:16:30 2023 +0200

    [gdb/symtab] Dump qualified name of cooked_index_entry

    When doing "maint print objfiles" for the exec of test-case
    gdb.dwarf2/pr13961.exp, we get:
    ...
        [25] ((cooked_index_entry *) 0x37b25d0)
        name:       foo
        canonical:  foo
        DWARF tag:  DW_TAG_class_type
        flags:      0x0 []
        DIE offset: 0x2a
        parent:     ((cooked_index_entry *) 0)

        [26] ((cooked_index_entry *) 0x37b2630)
        name:       foo
        canonical:  foo
        DWARF tag:  DW_TAG_class_type
        flags:      0x0 []
        DIE offset: 0x25
        parent:     ((cooked_index_entry *) 0x37b25d0) [foo]
    ...

    By following the parent links in the text, we can conclude that the
qualified
    name of DIE 0x25 is foo::foo (which is incorrect, that's PR symtab/3073=
9).

    But it's not evident, and also hard to verify in a test-case.

    Add dumping of the qualified name, such that we have:
    ...
        [25] ((cooked_index_entry *) 0x333b5d0)
        name:       foo
        canonical:  foo
        qualified:  foo
        DWARF tag:  DW_TAG_class_type
        flags:      0x0 []
        DIE offset: 0x2a
        parent:     ((cooked_index_entry *) 0)

        [26] ((cooked_index_entry *) 0x333b630)
        name:       foo
        canonical:  foo
        qualified:  foo::foo
        DWARF tag:  DW_TAG_class_type
        flags:      0x0 []
        DIE offset: 0x25
        parent:     ((cooked_index_entry *) 0x333b5d0) [foo]
    ...

    Tested on x86_64-linux.

    Approved-By: Tom Tromey <tom@tromey.com>

--=20
You are receiving this mail because:
You are on the CC list for the bug.=