public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug symtab/30739] New: [gdb/symtab] wrong Date: Wed, 09 Aug 2023 14:14:54 +0000 [thread overview] Message-ID: <bug-30739-4717@http.sourceware.org/bugzilla/> (raw) https://sourceware.org/bugzilla/show_bug.cgi?id=30739 Bug ID: 30739 Summary: [gdb/symtab] wrong Product: gdb Version: HEAD Status: NEW Severity: normal Priority: P2 Component: symtab Assignee: unassigned at sourceware dot org Reporter: vries at gcc dot gnu.org Target Milestone: --- I went looking for a test-case that triggers the m_deferred_entries case, and found gdb.dwarf2/pr13961.exp, which contains: ... <1><25>: Abbrev Number: 8 (DW_TAG_class_type) <26> DW_AT_specification: <0x2a> <1><2a>: Abbrev Number: 2 (DW_TAG_class_type) <2b> DW_AT_name : foo <2f> DW_AT_byte_size : 4 <30> DW_AT_decl_file : 1 <31> DW_AT_decl_line : 1 <32> DW_AT_sibling : <0x44> ... The DIE at 0x25 contains an intra-CU forward reference, and is deferred. Then I looked at the resulting cooked index entries: ... [12] ((cooked_index_entry *) 0x3dbbd00) name: foo canonical: foo DWARF tag: DW_TAG_class_type flags: 0x0 [] DIE offset: 0x25 parent: ((cooked_index_entry *) 0x3dbbca0) [foo] [13] ((cooked_index_entry *) 0x3dbbca0) name: foo canonical: foo DWARF tag: DW_TAG_class_type flags: 0x0 [] DIE offset: 0x2a parent: ((cooked_index_entry *) 0) ... and noticed that 0x2a is the parent of 0x25. The parent field is documented as: ... /* The parent entry. This is NULL for top-level entries. Otherwise, it points to the parent entry, such as a namespace or class. */ const cooked_index_entry *parent_entry; ... so I'd expect no parent for 0x25. I'd expect the current situation to match in a foo::foo name lookup. The parent is set here: ... for (const auto &entry : m_deferred_entries) { void *obj = m_die_range_map.find (entry.spec_offset); cooked_index_entry *parent = static_cast<cooked_index_entry *> (obj); m_index_storage->add (entry.die_offset, entry.tag, entry.flags, entry.name, parent, m_per_cu); } ... and AFAICT, we store in m_die_range_map the parent of the respective DIE (though that's not clear from the comment describing it). But, for DIE 0x2a we have m_die_range_map.find (0x2a) == 0x2a. AFAICT, this is an off-by-one error, fixed by: ... diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index dd4fac52ca8..d60a592669a 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -16477,7 +16477,7 @@ cooked_indexer::recurse (cutu_reader *reader, if (parent_entry != nullptr) { - CORE_ADDR start = form_addr (parent_entry->die_offset, + CORE_ADDR start = form_addr (parent_entry->die_offset + 1, reader->cu->per_cu->is_dwz); CORE_ADDR end = form_addr (sect_offset (info_ptr - 1 - reader->buffer), reader->cu->per_cu->is_dwz); ... which gives us: ... [12] ((cooked_index_entry *) 0x41e21f0) name: foo canonical: foo DWARF tag: DW_TAG_class_type flags: 0x0 [] DIE offset: 0x25 parent: ((cooked_index_entry *) 0) [13] ((cooked_index_entry *) 0x41e2190) name: foo canonical: foo DWARF tag: DW_TAG_class_type flags: 0x0 [] DIE offset: 0x2a parent: ((cooked_index_entry *) 0) ... -- You are receiving this mail because: You are on the CC list for the bug.
next reply other threads:[~2023-08-09 14:14 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-09 14:14 vries at gcc dot gnu.org [this message] 2023-08-09 14:15 ` [Bug symtab/30739] [gdb/symtab] wrong parent for cooked index entry vries at gcc dot gnu.org 2023-08-09 15:11 ` vries at gcc dot gnu.org 2023-08-10 19:16 ` cvs-commit at gcc dot gnu.org 2023-08-10 19:16 ` cvs-commit at gcc dot gnu.org 2023-08-10 19:19 ` vries at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-30739-4717@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).