[Bug symtab/30741] [gdb/symtab, cc-with-debug-names] gdb/dwarf2/index-write.c:1305: internal-error: write_debug_names: Assertion `counter == per_bfd->all_units.size ()' failed.

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30741

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
The assert fails because:
...
(gdb) 
#6  0x00000000006d9e63 in write_debug_names (per_bfd=0x35bff20,
table=0x35c6ea0, out_file=0x2be7d80, 
    out_file_str=0x35c8a10) at
/data/vries/gdb/src/gdb/dwarf2/index-write.c:1305
1305      gdb_assert (counter == per_bfd->all_units.size ());
(gdb) p counter
$1 = 6
(gdb) p per_bfd->all_units.size ()
$2 = 7
...

The .debug_info section has 6 CUs, the .debug_types section has 1.

This looks like a regression by commit 542a33e348a ("Only use the per-BFD
object to write a DWARF index"), which does:
...
-  gdb_assert (counter == per_objfile->per_bfd->all_comp_units.size ());
+  gdb_assert (counter == per_bfd->all_units.size ());
...

Fixed by reverting to all_comp_units.size:
...
diff --git a/gdb/dwarf2/index-write.c b/gdb/dwarf2/index-write.c
index 66c5378d677..fdc3b97968a 100644
--- a/gdb/dwarf2/index-write.c
+++ b/gdb/dwarf2/index-write.c
@@ -1302,7 +1302,7 @@ write_debug_names (dwarf2_per_bfd *per_bfd, cooked_index
*table,
     }

    /* Verify that all units are represented.  */
-  gdb_assert (counter == per_bfd->all_units.size ());
+  gdb_assert (counter == per_bfd->all_comp_units.size ());
   gdb_assert (types_counter == per_bfd->all_type_units.size ());

   for (const cooked_index_entry *entry : table->all_entries ())
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.