From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 204233860015; Mon, 27 Nov 2023 20:14:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 204233860015 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1701116071; bh=aAOKBDj0JXsKvPPZ7L5ko+yOGnn9/TGKAQOeexKDRAc=; h=From:To:Subject:Date:In-Reply-To:References:From; b=GQYEG2kbz7jsnrI1hEhOoJVp2IimAmwG7X8+Ab21a3vBUaM54QTgqfpniSNlzQaSP cbWtauvxt4QrtEbjfMmsY6CC2v8DgeU98NyCo02+rwF2cEJYVIU/jMzQJKJ9k4b/4D X8MjvCCjmNTa/bFMOdrCxzBMqgD6rOcz98L9grmM= From: "cvs-commit at gcc dot gnu.org" To: gdb-prs@sourceware.org Subject: [Bug remote/30770] serial.c does not preserve errno correctly Date: Mon, 27 Nov 2023 20:14:30 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: remote X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: cvs-commit at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: tromey at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30770 --- Comment #8 from Sourceware Commits --- The master branch has been updated by Tom Tromey : https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Da2e0acea420c= ca881296c6fcf58920f3d7c05a45 commit a2e0acea420cca881296c6fcf58920f3d7c05a45 Author: Tom Tromey Date: Fri Sep 1 12:11:37 2023 -0600 Change serial "open" functions to throw exception remote.c assumes that a failure to open the serial connection will set errno. This is somewhat true, because the Windows code tries to set errno appropriately -- but only somewhat, because it isn't clear that the "pex" code sets it, and the tcp code seems to do the wrong thing. It seems better to simply have the serial open functions throw on error. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30770 --=20 You are receiving this mail because: You are on the CC list for the bug.=