From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 4BC92385841C; Wed, 6 Sep 2023 08:15:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4BC92385841C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1693988111; bh=Fo4qWFZm+zQ3U81edNlt7O4Z3nLOSVkMyswDNynCsBM=; h=From:To:Subject:Date:In-Reply-To:References:From; b=O4A89ssXUBzPTkbKV4ZNjH0bmHRRqSSYBAbQV3pkpeiuySpu9mgQvMpJlp1taJ7II /F/VpV3+1Rjza+Ev3jtFLw4Yn2cn+McZcbnDwDcvYWxrKVBy4E8eRPQvL8ABMsCJ6J QeGlpnwB1Bs/KY+6xXvHBLQJJiMqCGUto5aXyICQ= From: "cvs-commit at gcc dot gnu.org" To: gdb-prs@sourceware.org Subject: [Bug symtab/30797] [gdb/symtab, cc-with-dwz] FAIL: gdb.base/setshow.exp: test_setshow_annotate: annotation_level 1 Date: Wed, 06 Sep 2023 08:15:09 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: symtab X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: cvs-commit at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30797 --- Comment #7 from cvs-commit at gcc dot gnu.org --- The master branch has been updated by Tom de Vries : https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D7023b8d86c6f= 2403a4d7337e0b55fa9290181a06 commit 7023b8d86c6f2403a4d7337e0b55fa9290181a06 Author: Tom de Vries Date: Wed Sep 6 10:14:50 2023 +0200 [gdb/symtab] Handle PU in iterate_over_some_symtabs When running test-case gdb.base/setshow.exp with target board cc-with-d= wz I run into: ... (gdb) info line 1^M Line 1 of "setshow.c" is at address 0x400527
but contains no cod= e.^M Line 1 of "setshow.c" is at address 0x400527
but contains no cod= e.^M (gdb) FAIL: gdb.base/setshow.exp: test_setshow_annotate: annotation_lev= el 1 ... while the expected output is: ... Line 1 of "setshow.c" is at address 0x400527
but contains no cod= e. =C3=AF=C2=BF=C2=BD=C3=AF=C2=BF=C2=BDsetshow.c:1:0:beg:0x400527 ... The second line of the expected output is missing due to the first line= of the expected output being repeated, so the problem is that the "Line 1" lin= e is printed twice. This happens because the PU imported by the CU reuses the filetab of the CU, and both the CU and PU are visited by iterate_over_some_symtabs. Fix this by skipping PUs in iterate_over_some_symtabs. Tested on x86_64-linux, target boards unix, cc-with-dwz and cc-with-dwz= -m. Approved-By: Tom Tromey PR symtab/30797 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30797 --=20 You are receiving this mail because: You are on the CC list for the bug.=