From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 053143857715; Tue, 12 Sep 2023 16:37:11 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 053143857715
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1694536632;
	bh=W7rRHgSCA6Pe5dZjSqPflfNAWYLoo2PaxvYLSSCh3uY=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=TqlcXmbGn2hEBdGMmWmlUyagHDl4AZ8t79/TyksG4oB9VcBlMxXXs0bgO75m7tYqn
	 H9pRo/wHMSm+lVx3k4HYbN9xeHtV6KaziIiMj7FnWGe8xnusa1/1IGctHHkx8NVGF8
	 1DZYgGZgxpbsnAXiAHWX3i3yJBflr51W4upEG2cw=
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug dap/30820] DAP GDB: Getting an error when bypassing "source" to
 breakpoint
Date: Tue, 12 Sep 2023 16:37:10 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: dap
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: tromey at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-30820-4717-a9A0bNoAQx@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-30820-4717@http.sourceware.org/bugzilla/>
References: <bug-30820-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D30820

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gn=
u.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Df8ab02700886=
3bd06513053ea9f84e1116c1cf73

commit f8ab027008863bd06513053ea9f84e1116c1cf73
Author: Tom Tromey <tromey@adacore.com>
Date:   Tue Sep 5 06:55:54 2023 -0600

    Avoid spurious breakpoint-setting failure in DAP

    A user pointed out that if a DAP setBreakpoints request has a 'source'
    field in a SourceBreakpoint object, then the gdb DAP implementation
    will throw an exception.

    While SourceBreakpoint does not allow 'source' in the spec, it seems
    better to me to accept it.  I don't think we should fully go down the
    "Postel's Law" path -- after all, we have the type-checker -- but at
    the same time, if we do send errors, they should be intentional and
    not artifacts of the implementation.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30820

--=20
You are receiving this mail because:
You are on the CC list for the bug.=