From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 1840138582B0; Mon,  4 Sep 2023 08:20:20 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1840138582B0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1693815621;
	bh=jhkqcTVN1oy2WUtskkQU/Ay5mhrsUlRm5i00HCnciTo=;
	h=From:To:Subject:Date:From;
	b=ujTSSs4mYzjmUleJBUFMdAu67Lk6EA3mf+3Jo1ACLgUgsmNHyHpnAja0I/Yhp3sq7
	 h67JzWCHTTSLyvoWihYWdsBhZzWOSLKBAz1A8bi3VMlZJHqSW4D3tMG3eX17wGEiv1
	 Dlavusdm9fr7MLeM37/dt5+dCW2z/teQjNZKxFlI=
From: "artem.sokolovskii at qt dot io" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug dap/30820] New: Error when bypassing "source" to breakpoint
Date: Mon, 04 Sep 2023 08:20:20 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: dap
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: artem.sokolovskii at qt dot io
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-30820-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D30820

            Bug ID: 30820
           Summary: Error when bypassing "source" to breakpoint
           Product: gdb
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: dap
          Assignee: unassigned at sourceware dot org
          Reporter: artem.sokolovskii at qt dot io
  Target Milestone: ---

I updated my gdb sources and built it today. I found out that breakpoint
structure was changed for gdb dap. Before it works correctly I could add
"source" field to "Breakpoint" structure(as it is written in the
dochttps://microsoft.github.io/debug-adapter-protocol/specification#Types_B=
reakpoint).
But now I shouldn't do this otherwise I'm not able to set breakpoints with =
an
error "gdb.dap.breakpoint._rewrite_src_breakpoint() got multiple values for
keyword argument 'source".
Could you please do as it was before?

Log:
How it works now. wo "source" field.
qtc.dbg.dapengine: "Content-Length:
166\r\n\r\n{\"arguments\":{\"breakpoints\":[{\"line\":16}],\"source\":{\"pa=
th\":\"/home/artem/work/testproj/untitled/mainwindow.cpp\"}},\"command\":\"=
setBreakpoints\",\"seq\":15,\"type\":\"request\"}"

How it worked before. with "source" field according to documentation.=20
qtc.dbg.dapengine: "Content-Length:
260\r\n\r\n{\"arguments\":{\"breakpoints\":[{\"line\":16,\"source\":{\"name=
\":\"mainwindow.cpp\",\"path\":\"/home/artem/work/testproj/untitled/mainwin=
dow.cpp\"}}],\"source\":{\"path\":\"/home/artem/work/testproj/untitled/main=
window.cpp\"}},\"command\":\"setBreakpoints\",\"seq\":15,\"type\":\"request=
\"}"
qtc.dbg.dapengine: insertBreakpoint 1 "1"
qtc.dbg.dapengine: "Content-Length: 207\r\n\r\n{\"request_seq\": 15, \"type=
\":
\"response\", \"command\": \"setBreakpoints\", \"success\": false, \"messag=
e\":
\"gdb.dap.breakpoint._rewrite_src_breakpoint() got multiple values for keyw=
ord
argument 'source'\", \"seq\": 177}"

--=20
You are receiving this mail because:
You are on the CC list for the bug.=