[Bug symtab/30827] [gdb/symtab, dwarf4-gdb-index] FAIL: gdb.ada/same_enum.exp: print red

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30827

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=be7d5d2c417a842452f5f5d4ed7fc8d058a970bf

commit be7d5d2c417a842452f5f5d4ed7fc8d058a970bf
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu Sep 7 21:59:33 2023 +0200

    [gdb/symtab] Fix gdb-index writing for .debug_types

    With test-case gdb.ada/same_enum.exp and target board dwarf4-gdb-index we
run
    into:
    ...
    (gdb) print red^M
    No definition of "red" in current context.^M
    (gdb) FAIL: gdb.ada/same_enum.exp: print red
    ...

    [ This is a regression since commit 844a72efbce ("Simplify gdb_index
writing"),
    so this is broken in gdb 12 and 13. ]

    The easiest way to see what's going wrong is with readelf.  We have in
section
    .gdb_index:
    ...
    [7194] pck__red:
            2 [static, variable]
            3 [static, variable]
    ...
    which points to the CUs 2 and 3 in the CU list (shown using "2" and "3"),
but
    should be pointing to the TUs 2 and 3 in the TU list (shown using "T2" and
    "T3").

    Fix this by removing the counter / types_counter distinction in
    write_gdbindex, such that we get the expected:
    ...
    [7194] pck__red:
            T2 [static, variable]
            T3 [static, variable]
    ...

    [ While reading write_gdbindex I noticed a few oddities related to dwz
    handling, I've filed PR30829 about this. ]

    Tested on x86_64-linux.

    Approved-By: Tom Tromey <tom@tromey.com>

    PR symtab/30827
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30827

-- 
You are receiving this mail because:
You are on the CC list for the bug.