public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/30829] New: [gdb/symtab] Review write_gdbindex for dwz
Date: Thu, 07 Sep 2023 13:15:31 +0000	[thread overview]
Message-ID: <bug-30829-4717@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=30829

            Bug ID: 30829
           Summary: [gdb/symtab] Review write_gdbindex for dwz
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: minor
          Priority: P2
         Component: symtab
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

While working on fixing PR3082, I noticed a few things in write_gdbindex.

We do this:
...
      const auto insertpair = cu_index_htab.emplace (per_cu, counter);
...
which looks incorrect for per_cu->is_dwz.

Then we do:
...
      data_buf &cu_list = (per_cu->is_debug_types
                           ? types_cu_list
                           : per_cu->is_dwz ? dwz_cu_list : objfile_cu_list);
  ...
  write_gdbindex_1 (dwz_out_file, dwz_cu_list, {}, {}, {}, {});
...
which seems to exclude the possibility that a dwz file has a .debug_types
section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2023-09-07 13:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-07 13:15 vries at gcc dot gnu.org [this message]
2023-09-07 17:50 ` [Bug symtab/30829] " tromey at sourceware dot org
2023-09-08  5:54 ` vries at gcc dot gnu.org
2023-09-08 12:59 ` vries at gcc dot gnu.org
2023-09-08 13:14 ` vries at gcc dot gnu.org
2023-09-08 13:24 ` vries at gcc dot gnu.org
2023-09-12  8:46 ` vries at gcc dot gnu.org
2023-09-12 10:01 ` vries at gcc dot gnu.org
2023-09-12 10:05 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30829-4717@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).