From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id CCF183858D20; Thu,  7 Sep 2023 13:15:31 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CCF183858D20
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1694092531;
	bh=M83TgDz30ubRUAqaHRkCxnxQ/hvMVN33P7DGnjelA2w=;
	h=From:To:Subject:Date:From;
	b=LDLEJeuvai9sG88iloZgFM3lMIpaNvAxPEJ66H/S+dKZFehdNECFeMHDPodTxvNU8
	 S2CI+F/z7Xb2t95MbB9+RE+Zj7TlJ0Z2XL0DlPfyx8QPSqAYM5I+2OLEDJ9ft8IH9s
	 xoPW0D4MGd1eZsA/Mgo6LalmWvx7ouZW77XM0iq8=
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/30829] New: [gdb/symtab] Review write_gdbindex for dwz
Date: Thu, 07 Sep 2023 13:15:31 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: symtab
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: minor
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-30829-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D30829

            Bug ID: 30829
           Summary: [gdb/symtab] Review write_gdbindex for dwz
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: minor
          Priority: P2
         Component: symtab
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

While working on fixing PR3082, I noticed a few things in write_gdbindex.

We do this:
...
      const auto insertpair =3D cu_index_htab.emplace (per_cu, counter);
...
which looks incorrect for per_cu->is_dwz.

Then we do:
...
      data_buf &cu_list =3D (per_cu->is_debug_types
                           ? types_cu_list
                           : per_cu->is_dwz ? dwz_cu_list : objfile_cu_list=
);
  ...
  write_gdbindex_1 (dwz_out_file, dwz_cu_list, {}, {}, {}, {});
...
which seems to exclude the possibility that a dwz file has a .debug_types
section.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=