[Bug symtab/30846] [gdb/symtab] incorrect parent for forward spec (inter-cu case)

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30846

--- Comment #3 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4320a9c921db0245e9486bf3144a326434919f15

commit 4320a9c921db0245e9486bf3144a326434919f15
Author: Tom Tromey <tom@tromey.com>
Date:   Fri Jan 12 18:29:52 2024 -0700

    Correctly handle DIE parent computations

    Tom de Vries pointed out that the combination of sharding,
    multi-threading, and per-CU "racing" means that sometimes a cross-CU
    DIE reference might not be correctly resolved.  However, it's
    important to handle this correctly, due to some unfortunate aspects of
    DWARF.

    This patch implements this by arranging to preserve each worker's DIE
    map through the end of index finalization.  The extra data is
    discarded when finalization is done.  This approach also allows the
    parent name resolution to be sharded, by integrating it into the
    existing entry finalization loop.

    In an earlier review, I remarked that addrmap couldn't be used here.
    However, I was mistaken.  A *mutable* addrmap cannot be used, as those
    are based on splay trees and restructure the tree even during lookups
    (and thus aren't thread-safe).  A fixed addrmap, on the other hand, is
    just a vector and is thread-safe.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30846

-- 
You are receiving this mail because:
You are on the CC list for the bug.