[Bug symtab/30871] [gdb/symtab] Means to control finding debuginfo (without/with sysroot prefix)

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30871

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Andrew Burgess from comment #2)
> Hi Tom,
> 
> I was taking a look at this, and I wasn't clear on why we need a new
> maintenance command?
> 
> Your point seems solid: there are no tests for finding debug information
> using the sysroot, but isn't the fix to that just to add such a test?  How
> does the new maintenance command help us?
> 
> Anyway, I posted this:
> 
> https://inbox.sourceware.org/gdb-patches/cover.1716214388.git.
> aburgess@redhat.com
> 
> As an attempt to address this patch.  I can look at extending it if some
> case isn't being covered sufficiently.

Hi Andrew,

I think you're right, a new (maintenance) command isn't necessary to test the
behaviour.

I think I conflated two ideas in this PR:
- IWBN to have a command to show and control how debuginfo is found,
determining
  allowed methods (build-id/debug-link/both, with/without sysroot/both) and
  order in which they're tried.
- a test-case for finding debuginfo via the sysroot is missing

When filing the PR I thought of the test-case in terms of using the command. 
But it's also possible to write a test-case to check one scenario by making
sure the other scenarios will fail, which I suppose is what you have done in
the patch series.

Anyway, I'll take a look at the series, thanks for taking care of the missing
test-case.

You mention extending the test-case, and one thing I can think of that is
nice-to-have, is using symlinks, in other words exercising PR30866 and adding a
KFAIL for that.

As for the command, AFAIC it's a nice-to-have which could be useful.  For
instance, my guess is that users who set up debug info on the sysroot might
want to have a means to skip trying to look up debug packages without the
sysroot prefix.  But if there's no demand for it, I'm more than happy to drop
it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.