[Bug gdb/30912] New: Regression: make check TESTS="gdb.base/gcore.exp" RUNTESTFLAGS="--target_board=native-extended-gdbserver"

[Bug gdb/30912] New: Regression: make check TESTS="gdb.base/gcore.exp" RUNTESTFLAGS="--target_board=native-extended-gdbserver"

[simon.marchi at polymtl dot ca]

https://sourceware.org/bugzilla/show_bug.cgi?id=30912

            Bug ID: 30912
           Summary: Regression: make check TESTS="gdb.base/gcore.exp"
                    RUNTESTFLAGS="--target_board=native-extended-gdbserver
                    "
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gdb
          Assignee: unassigned at sourceware dot org
          Reporter: simon.marchi at polymtl dot ca
  Target Milestone: ---

Commit:

https://gitlab.com/gnutools/binutils-gdb/-/commit/24ef2641d917695470fb2d43dabb133e3ee6678f

introduced this failure, when testing with the native-extended-gdbserver board:

FAIL: gdb.base/gcore.exp: corefile restored all registers

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/30912] Regression: make check TESTS="gdb.base/gcore.exp" RUNTESTFLAGS="--target_board=native-extended-gdbserver"

[brobecker at gnat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30912

Joel Brobecker <brobecker at gnat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brobecker at gnat dot com
   Target Milestone|---                         |14.1

--- Comment #1 from Joel Brobecker <brobecker at gnat dot com> ---
Setting the milestone to 14.1 as per Simon's request (regression).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/30912] Regression: make check TESTS="gdb.base/gcore.exp" RUNTESTFLAGS="--target_board=native-extended-gdbserver"

[brobecker at gnat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30912

--- Comment #2 from Joel Brobecker <brobecker at gnat dot com> ---
FTR, marked as IN for 14.1 because it's a regression from GDB 13.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/30912] Regression: make check TESTS="gdb.base/gcore.exp" RUNTESTFLAGS="--target_board=native-extended-gdbserver"

[brobecker at gnat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30912

--- Comment #3 from Joel Brobecker <brobecker at gnat dot com> ---
Hi Simon,

Do you know if anyone is working on this PR? John (author of the patch you
identified below) maybe? For the GDB 14.1 release, I'm hoping that we can
publish it during the weekend of Nov 18-19, and since this one is a regression
that we are trying to fix in 14.1, it would be nice to confirm whether someone
is on it or not. If not, we may decide to skip it for 14.1 and perhaps aim for
14.2 instead.

Thank you!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/30912] Regression: make check TESTS="gdb.base/gcore.exp" RUNTESTFLAGS="--target_board=native-extended-gdbserver"

[simark at simark dot ca]

https://sourceware.org/bugzilla/show_bug.cgi?id=30912

Simon Marchi <simark at simark dot ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simark at simark dot ca

--- Comment #4 from Simon Marchi <simark at simark dot ca> ---
IIRC, this failure was introduced with the XSAVE work, but I don't remember the
specifics of why the test passed before and it doesn't now.  It's likely
related to the fact that we don't have a way for GDB to get the CPUID
information from GDBserver (John can confirm).

Looking at the failure a bit more in details, when doing "info all-reg" we
expect this (I only included ymm0 for brevity, but it's ymm0 to ymm15):

ymm0           {v16_bfloat16 = {0xc300, 0xf7e9, 0x7fff, 0x0, 0xc300, 0xf7e9,
0x7fff, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}, v16_half = {0xc300,
0xf7e9, 0x7fff, 0x0, 0xc300, 0xf7e9, 0x7fff, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
0x0, 0x0}, v8_float = {0xf7e9c300, 0x7fff, 0xf7e9c300, 0x7fff, 0x0, 0x0, 0x0,
0x0}, v4_double = {0x7ffff7e9c300, 0x7ffff7e9c300, 0x0, 0x0}, v32_int8 = {0x0,
0xc3, 0xe9, 0xf7, 0xff, 0x7f, 0x0, 0x0, 0x0, 0xc3, 0xe9, 0xf7, 0xff, 0x7f, 0x0
<repeats 18 times>}, v16_int16 = {0xc300, 0xf7e9, 0x7fff, 0x0, 0xc300, 0xf7e9,
0x7fff, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}, v8_int32 = {0xf7e9c300,
0x7fff, 0xf7e9c300, 0x7fff, 0x0, 0x0, 0x0, 0x0}, v4_int64 = {0x7ffff7e9c300,
0x7ffff7e9c300, 0x0, 0x0}, v2_int128 = {0x7ffff7e9c30000007ffff7e9c300, 0x0}}

but get:

ymm0           {v16_bfloat16 = {0xc300, 0xf7e9, 0x7fff, 0x0, 0xc300, 0xf7e9,
0x7fff, 0x0, <unavailable>, <unavailable>, <unavailable>, <unavailable>,
<unavailable>, <unavailable>, <unavailable>, <unavailable>}, v16_half =
{0xc300, 0xf7e9, 0x7fff, 0x0, 0xc300, 0xf7e9, 0x7fff, 0x0, <unavailable>,
<unavailable>, <unavailable>, <unavailable>, <unavailable>, <unavailable>,
<unavailable>, <unavailable>}, v8_float = {0xf7e9c300, 0x7fff, 0xf7e9c300,
0x7fff, <unavailable>, <unavailable>, <unavailable>, <unavailable>}, v4_double
= {0x7ffff7e9c300, 0x7ffff7e9c300, <unavailable>, <unavailable>}, v32_int8 =
{0x0, 0xc3, 0xe9, 0xf7, 0xff, 0x7f, 0x0, 0x0, 0x0, 0xc3, 0xe9, 0xf7, 0xff,
0x7f, 0x0, 0x0, <unavailable> <repeats 16 times>}, v16_int16 = {0xc300, 0xf7e9,
0x7fff, 0x0, 0xc300, 0xf7e9, 0x7fff, 0x0, <unavailable>, <unavailable>,
<unavailable>, <unavailable>, <unavailable>, <unavailable>, <unavailable>,
<unavailable>}, v8_int32 = {0xf7e9c300, 0x7fff, 0xf7e9c300, 0x7fff,
<unavailable>, <unavailable>, <unavailable>, <unavailable>}, v4_int64 =
{0x7ffff7e9c300, 0x7ffff7e9c300, <unavailable>, <unavailable>}, v2_int128 =
{0x7ffff7e9c30000007ffff7e9c300, <unavailable>}}

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/30912] Regression: make check TESTS="gdb.base/gcore.exp" RUNTESTFLAGS="--target_board=native-extended-gdbserver"

[jhb at FreeBSD dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30912

jhb at FreeBSD dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jhb at FreeBSD dot org

--- Comment #5 from jhb at FreeBSD dot org ---
Sorry I didn't see this earlier for some reason, yes, this is related to the
fact that when using gdbserver, GDB doesn't know what layout to use when
writing out a core dump.

The long term solution is to pull the CPUID info from gdbserver in the form of
NT_X86_CPUID, but in the short term we could just always use the Intel layout
that GDB assumed before the XSAVE series.  That is, we could pick a default
layout based on the XCR0 mask that corresponds to one of the known sizes and
use that to set both the layout and size.  I'll see if I can't come up with a
variant of that today or tomorrow.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/30912] Regression: make check TESTS="gdb.base/gcore.exp" RUNTESTFLAGS="--target_board=native-extended-gdbserver"

[jhb at FreeBSD dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30912

jhb at FreeBSD dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |jhb at FreeBSD dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/30912] Regression: make check TESTS="gdb.base/gcore.exp" RUNTESTFLAGS="--target_board=native-extended-gdbserver"

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30912

--- Comment #6 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by John Baldwin <jhb@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=66637e209cc836c19a21a28e91046649c7702037

commit 66637e209cc836c19a21a28e91046649c7702037
Author: John Baldwin <jhb@FreeBSD.org>
Date:   Mon Nov 27 13:53:22 2023 -0800

    i386: Use a fallback XSAVE layout for remote targets

    If a target provides a target description including registers from the
    XSAVE extended region, but does not provide an XSAVE layout, use a
    fallback XSAVE layout based on the included registers.  This fallback
    layout matches GDB's behavior in earlier releases which assumes the
    layout from Intel CPUs.

    This fallback layout is currently only used for remote targets since
    native targets which support XSAVE provide an explicit layout derived
    from CPUID.

    PR gdb/30912
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30912
    Approved-By: Simon Marchi <simon.marchi@efficios.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/30912] Regression: make check TESTS="gdb.base/gcore.exp" RUNTESTFLAGS="--target_board=native-extended-gdbserver"

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30912

--- Comment #7 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The gdb-14-branch branch has been updated by John Baldwin <jhb@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=823c11ef481acd1b1e768302e702ae998cc1de70

commit 823c11ef481acd1b1e768302e702ae998cc1de70
Author: John Baldwin <jhb@FreeBSD.org>
Date:   Mon Nov 27 13:53:22 2023 -0800

    i386: Use a fallback XSAVE layout for remote targets

    If a target provides a target description including registers from the
    XSAVE extended region, but does not provide an XSAVE layout, use a
    fallback XSAVE layout based on the included registers.  This fallback
    layout matches GDB's behavior in earlier releases which assumes the
    layout from Intel CPUs.

    This fallback layout is currently only used for remote targets since
    native targets which support XSAVE provide an explicit layout derived
    from CPUID.

    PR gdb/30912
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30912
    Approved-By: Simon Marchi <simon.marchi@efficios.com>

    (cherry picked from commit 66637e209cc836c19a21a28e91046649c7702037)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/30912] Regression: make check TESTS="gdb.base/gcore.exp" RUNTESTFLAGS="--target_board=native-extended-gdbserver"

[jhb at FreeBSD dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30912

jhb at FreeBSD dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #8 from jhb at FreeBSD dot org ---
Fix merged to master and gdb-14-branch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.