[Bug remote/30927] New: gdbsupport/configure does not detect Illumos socketpair

[Bug remote/30927] New: gdbsupport/configure does not detect Illumos socketpair

[pjfloyd at wanadoo dot fr]

https://sourceware.org/bugzilla/show_bug.cgi?id=30927

            Bug ID: 30927
           Summary: gdbsupport/configure does not detect Illumos
                    socketpair
           Product: gdb
           Version: HEAD
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: remote
          Assignee: unassigned at sourceware dot org
          Reporter: pjfloyd at wanadoo dot fr
  Target Milestone: ---

(not checked on Solaris, possibly the same)

gdb/configure.ac has special detection for libsocket:

# Some systems (e.g. Solaris) have `socketpair' in libsocket.
AC_SEARCH_LIBS(socketpair, socket)

I think the equivalent for gdbsupport is common.m4 which just has "plain"
(libc) detection of socketpair

  AC_CHECK_FUNCS([fdwalk getrlimit pipe pipe2 poll socketpair sigaction \
                  ptrace64 sbrk setns sigaltstack sigprocmask \
                  setpgid setpgrp getrusage getauxval sigtimedwait])


As a result config.h does not get HAVE_SOCKETPAIR defined.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug remote/30927] gdbsupport/configure does not detect Illumos socketpair

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30927

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
Created attachment 15148
  --> https://sourceware.org/bugzilla/attachment.cgi?id=15148&action=edit
patch

Can you try this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug remote/30927] gdbsupport/configure does not detect Illumos socketpair

[pjfloyd at wanadoo dot fr]

https://sourceware.org/bugzilla/show_bug.cgi?id=30927

--- Comment #2 from Paul Floyd <pjfloyd at wanadoo dot fr> ---
The patch looks OK for gdbsupport/common.m4 but I don't think that
gdb/configure.ac needs changing.

With the test for socketpait in libsocket removed gdb/config.h doesn't get
HAVE_SOCKETPAIR set which is used by gdb/ser-pipe.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug remote/30927] gdbsupport/configure does not detect Illumos socketpair

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30927

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
(In reply to Paul Floyd from comment #2)
> The patch looks OK for gdbsupport/common.m4 but I don't think that
> gdb/configure.ac needs changing.
> 
> With the test for socketpait in libsocket removed gdb/config.h doesn't get
> HAVE_SOCKETPAIR set which is used by gdb/ser-pipe.c

This is surprising because the patch just moves the check
from gdb to common.m4, which is used by both programs.
Did you do a clean rebuild?  Maybe look in gdb/config.log
to see what has gone wrong.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug remote/30927] gdbsupport/configure does not detect Illumos socketpair

[pjfloyd at wanadoo dot fr]

https://sourceware.org/bugzilla/show_bug.cgi?id=30927

--- Comment #4 from Paul Floyd <pjfloyd at wanadoo dot fr> ---
I think it's a problem of the order of execution.

AC_SEARCH_LIBs(socketpair, socket) needs to be done before AC_CHECK_FUNCS (so
that CHECK_FUNCS uses -lsocket) but now in gdb/configure it's being done after.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug remote/30927] gdbsupport/configure does not detect Illumos socketpair

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30927

--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
(In reply to Paul Floyd from comment #4)
> I think it's a problem of the order of execution.
> 
> AC_SEARCH_LIBs(socketpair, socket) needs to be done before AC_CHECK_FUNCS
> (so that CHECK_FUNCS uses -lsocket) but now in gdb/configure it's being done
> after.

Ok, I see.
I have an updated patch I'll post in a sec.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug remote/30927] gdbsupport/configure does not detect Illumos socketpair

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30927

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15148|0                           |1
        is obsolete|                            |

--- Comment #6 from Tom Tromey <tromey at sourceware dot org> ---
Created attachment 15153
  --> https://sourceware.org/bugzilla/attachment.cgi?id=15153&action=edit
new patch

Can you try this one?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug remote/30927] gdbsupport/configure does not detect Illumos socketpair

[pjfloyd at wanadoo dot fr]

https://sourceware.org/bugzilla/show_bug.cgi?id=30927

--- Comment #7 from Paul Floyd <pjfloyd at wanadoo dot fr> ---
Tested it this morning and it looks OK now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug remote/30927] gdbsupport/configure does not detect Illumos socketpair

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30927

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug remote/30927] gdbsupport/configure does not detect Illumos socketpair

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30927

--- Comment #8 from Tom Tromey <tromey at sourceware dot org> ---
https://sourceware.org/pipermail/gdb-patches/2023-October/203028.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug remote/30927] gdbsupport/configure does not detect Illumos socketpair

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30927

--- Comment #9 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The gdb-14-branch branch has been updated by Tom Tromey
<tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a0939697c360dba39661cddcde122a006e830482

commit a0939697c360dba39661cddcde122a006e830482
Author: Tom Tromey <tom@tromey.com>
Date:   Sun Oct 1 09:16:13 2023 -0600

    Move -lsocket check to common.m4

    A user pointed out that the -lsocket check in gdb should also apply to
    gdbserver -- otherwise it can't find the Solaris socketpair.  This
    patch makes the change.  It also removes a couple of redundant
    function checks from gdb's configure.ac.

    This was tested by the person who reported the bug.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30927
    Approved-By: Pedro Alves <pedro@palves.net>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug remote/30927] gdbsupport/configure does not detect Illumos socketpair

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30927

--- Comment #10 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5772d798236d493a0cdfd75b41520527e3129759

commit 5772d798236d493a0cdfd75b41520527e3129759
Author: Tom Tromey <tom@tromey.com>
Date:   Sun Oct 1 09:16:13 2023 -0600

    Move -lsocket check to common.m4

    A user pointed out that the -lsocket check in gdb should also apply to
    gdbserver -- otherwise it can't find the Solaris socketpair.  This
    patch makes the change.  It also removes a couple of redundant
    function checks from gdb's configure.ac.

    This was tested by the person who reported the bug.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30927
    Approved-By: Pedro Alves <pedro@palves.net>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug remote/30927] gdbsupport/configure does not detect Illumos socketpair

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30927

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |14.1
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #11 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.