[Bug symtab/31010] Evaluating "mixed-cased" fundamental types causes hangs/OOM due to full symtab expansion

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31010

--- Comment #9 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=aab2ac34d7f78f0b7a42cef0187dc6e4d7ec4f02

commit aab2ac34d7f78f0b7a42cef0187dc6e4d7ec4f02
Author: Tom Tromey <tom@tromey.com>
Date:   Fri Feb 21 09:18:28 2025 -0700

    Avoid excessive CU expansion on failed matches

    PR symtab/31010 points out that something like "ptype INT" will expand
    all CUs in a typical program.  The OP further points out that the
    original patch for PR symtab/30520:

        https://sourceware.org/pipermail/gdb-patches/2024-January/205924.html

    ... did solve the problem, but the patch changed after (my) review and
    reintroduced the bug.

    In cooked_index_functions::expand_symtabs_matching, the final
    component of a split name is compared with the entry's name using the
    usual method of calling get_symbol_name_matcher.

    This code iterates over languages and tries to split the original name
    according to each style.  But, the Ada splitter uses the decoded name
    -- "int".  This causes every C or C++ CU to be expanded.

    Clearly this is wrong.  And, it seems to me that looping over
    languages and trying to guess the splitting style for the input text
    is probably bad.  However, fixing the problem is not so easy (again
    due to Ada).  I've filed a follow-up bug, PR symtab/32733, for this.

    Meanwhile, this patch changes the code to be closer to the
    originally-submitted patch.  This works because the comparison is now
    done between the full name and the "lookup_name_without_params"
    object, which is a less adulterated variant of the original input.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31010
    Tested-By: Simon Marchi <simon.marchi@efficios.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.