From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 8CF313858CDB; Tue,  7 Nov 2023 18:40:30 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8CF313858CDB
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1699382430;
	bh=9dOnoinyl3+2Ral4sXONcVPY4Vjgejhok0WwA1R1dK4=;
	h=From:To:Subject:Date:From;
	b=LPlx1CbUgxSdiJQRkdDR7DtinJy2evz7Gz95UoEVd3sI43mduQfChFHuZnygzrh/K
	 /QGAVMdhllSKYCb1apaMIbCMi7WAF7qZ9DNlV56XmNo/YV4H7oJE8jirk8E7ym5pBs
	 qg+vVXizGsM3R1eZUXKNTxf4FevWd6CDjYMrVVDM=
From: "tromey at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/31041] New: some symtab code incorrectly uses
 perror_with_name
Date: Tue, 07 Nov 2023 18:40:30 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: symtab
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: tromey at sourceware dot org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-31041-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D31041

            Bug ID: 31041
           Summary: some symtab code incorrectly uses perror_with_name
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: symtab
          Assignee: unassigned at sourceware dot org
          Reporter: tromey at sourceware dot org
  Target Milestone: ---

I found this in coffread.c:

  val =3D bfd_seek (objfile->obfd.get (), symtab_offset, 0);
  if (val < 0)
    perror_with_name (objfile_name (objfile));

This is calling a BFD function but expecting an error
in errno.  Instead it should inspect the BFD error.

There is similar code in dbxread.c and xcoffread.c.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=