public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug build/31099] New: [gdb/build] -DNDEBUG missing in python flags of release build
Date: Thu, 30 Nov 2023 08:45:43 +0000	[thread overview]
Message-ID: <bug-31099-4717@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=31099

            Bug ID: 31099
           Summary: [gdb/build] -DNDEBUG missing in python flags of
                    release build
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

Before commit db6878ac553 ("Move sourcing of development.sh to GDB_AC_COMMON")
we have:
...
. $srcdir/../bfd/development.sh
  ...
    $development || tentative_python_cflags="$tentative_python_cflags -DNDEBUG"
...
but after:
...
    $development || tentative_python_cflags="$tentative_python_cflags -DNDEBUG"
  ...
. $srcdir/../bfd/development.sh
...

Curiously, while this gives an error:
...
$  && echo bla
bash: syntax error near unexpected token `&&'
$  || echo bla
bash: syntax error near unexpected token `||'
...
an empty var seems to be handled similar to ':' or 'true':
...
$ $empty && echo bla
bla
$ $empty || echo bla
$ 
...

So, the -DNDEBUG is not added in a release branch.

Regression since gdb 10.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2023-11-30  8:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-30  8:45 vries at gcc dot gnu.org [this message]
2023-11-30 11:22 ` [Bug build/31099] " vries at gcc dot gnu.org
2023-11-30 20:31 ` cvs-commit at gcc dot gnu.org
2023-11-30 20:33 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31099-4717@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).