[Bug python/31172] gdb.post_event SIGSEGV in batch mode

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31172

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vries at gcc dot gnu.org

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Tentative fix, similar to what is done for finalize_values:
...
diff --git a/gdb/run-on-main-thread.c b/gdb/run-on-main-thread.c
index 2d40048de56..e06b751f221 100644
--- a/gdb/run-on-main-thread.c
+++ b/gdb/run-on-main-thread.c
@@ -33,6 +33,14 @@ static struct serial_event *runnable_event;

 static std::vector<std::function<void ()>> runnables;

+/* See run-on-main-thread.h.  */
+
+void
+finalize_runnables (void)
+{
+  runnables.clear ();
+}
+
 #if CXX_STD_THREAD

 /* Mutex to hold when handling RUNNABLE_EVENT or RUNNABLES.  */
diff --git a/gdb/run-on-main-thread.h b/gdb/run-on-main-thread.h
index 4f370dddb9e..27eaff3df72 100644
--- a/gdb/run-on-main-thread.h
+++ b/gdb/run-on-main-thread.h
@@ -29,4 +29,8 @@ extern void run_on_main_thread (std::function<void ()> &&);

 extern bool is_main_thread ();

+/* Destroy the runnables currently allocated.  This is called when GDB is
+   exiting (e.g., on quit_force).  */
+extern void finalize_runnables ();
+
 #endif /* GDB_RUN_ON_MAIN_THREAD_H */
diff --git a/gdb/top.c b/gdb/top.c
index fb15c719564..221ef329951 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -74,6 +74,7 @@
 #include "cli-out.h"
 #include "tracepoint.h"
 #include "inf-loop.h"
+#include "run-on-main-thread.h"

 #if defined(TUI)
 # include "tui/tui.h"
@@ -1813,6 +1814,10 @@ quit_force (int *exit_arg, int from_tty)
      runtime, which is finalized via a final cleanup.  */
   finalize_values ();

+  /* Likewise, destroy any runnables currenctly allocated now.  The destructor
+     of gdbpy_event calls into the Python runtime.  */
+  finalize_runnables ();
+
   /* Do any final cleanups before exiting.  */
   try
     {
...

With this patch, we have:
...
$ gdb --batch -ex 'pi gdb.post_event(lambda : print("test"))' 
$ 
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.