From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 53B14386C591; Thu, 21 Dec 2023 17:22:42 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 53B14386C591
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1703179362;
	bh=Z9xdf6ndYxpVhykv68AitrdQDm+bA0FA2/xNhJF4UEo=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=bSZULt2rEjWxJuZRJDl9lQaV8Mn127uw26luzK5AXUBNb5mzAFrysQi+vGK8o4PKj
	 b6o/bm9o7I4CgN01HC7x0tmjUDmNPuFoPz38x7qdQc1Lhvhhaw7+UoLMr3HKUdVXdB
	 JS4Gi2pNgmw7fj7g0zAyC/yWcV5ur0vBGnPYYnl0=
From: "vapier at gentoo dot org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug sim/31181] sim: cris: decode unused base_insn variable warnings
Date: Thu, 21 Dec 2023 17:22:42 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: sim
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vapier at gentoo dot org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-31181-4717-eKBJXzqfd4@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-31181-4717@http.sourceware.org/bugzilla/>
References: <bug-31181-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D31181

--- Comment #10 from Mike Frysinger <vapier at gentoo dot org> ---
(In reply to Hans-Peter Nilsson from comment #9)
> That last line seems superfluous and should yield errors.  (Accidentally
> quoted an untested diff?)

yeah i didn't delete my partial comment ... already fixed it when i posted =
to
the cgen mailing list

> Beware that (IIRC) not
> all compilers (old gcc, perhaps *cough* clang) support the same *location*
> for the attribute (here, before the type).  The canonical position is aft=
er;
> "before the ';'".

ok, easy enough to update

> > +        "CGEN_INSN_WORD insn =3D "
> >          (if (adata-integral-insn? CURRENT-ARCH)
> >              "entire_insn;\n"
> >              "base_insn;\n"))
>=20
> I don't know whether the "adata-integral-insn?" predicate has bearing on
> whether insn can be "unused". Still: besides the superfluous line, I'd say
> time to post it for review, with a link to this PR.

i have no idea about adata-integral-insn here.  i went with it because all =
the
unused warnings are coming from insn=3Dbase_insn, not insn=3Dentire_insn, a=
nd
adata-integral-insn controls whether it's entire_insn or base_insn.

i'll cc you on the v2 patch on the cgen list.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=