From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 717F7385829C; Tue, 9 Jan 2024 16:57:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 717F7385829C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1704819444; bh=3prM5FJAQ2lkbHyKSkvGclNUlAmMv5eSXhW0jxwcBa8=; h=From:To:Subject:Date:In-Reply-To:References:From; b=TWZcXgrNPQ/0O5UHrbMSBhXdrfr+JtATTGhVodu51qnQE+KEILv6RufZr47UzVLCc qiBvxGa8CZJwAvFq09WXPwF42xESZ34Uc5QBacucyIrz+hjAbHVRCyaxAGgcIfwim0 CJrrUJJM5OT9xkr/oxXPEji7ZrnX3xpc958krX3M= From: "vries at gcc dot gnu.org" To: gdb-prs@sourceware.org Subject: [Bug gdb/31203] [gdb] FAIL: gdb.base/kill-during-detach.exp: exit_p=true: checkpoint_p=true: python kill_and_detach() Date: Tue, 09 Jan 2024 16:57:23 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: gdb X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: vries at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D31203 --- Comment #12 from Tom de Vries --- (In reply to Kevin Buettner from comment #11) > (In reply to Tom de Vries from comment #10) > > Not sure if this is the right place or way, but this fixes the FAIL: > > ... > > diff --git a/gdb/linux-fork.c b/gdb/linux-fork.c > > index 1430ff89fa7..0d97ec1ba04 100644 > > --- a/gdb/linux-fork.c > > +++ b/gdb/linux-fork.c > > @@ -228,6 +228,8 @@ fork_load_infrun_state (struct fork_info *fp) > > inferior_thread ()->set_stop_pc > > (regcache_read_pc (get_thread_regcache (inferior_thread ()))); > > nullify_last_target_wait_ptid (); > > + inferior_thread ()->set_executing (false); > > + inferior_thread ()->set_resumed (false); > >=20=20 > > /* Now restore the file positions of open file descriptors. */ > > if (fp->filepos) > > ... >=20 > There are multiple problems with linux-fork.c that need to be addressed > at some point, but your patch looks reasonable to me. Thanks for the pre-submission review, submitted ( https://sourceware.org/pipermail/gdb-patches/2024-January/205754.html ). --=20 You are receiving this mail because: You are on the CC list for the bug.=