public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/31211] [gdb] info checkpoints show incorrect info
Date: Wed, 10 Jan 2024 10:27:09 +0000	[thread overview]
Message-ID: <bug-31211-4717-lqP1AzE7cG@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31211-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=31211

--- Comment #3 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=cdf2a0febd8a20ef74e782bdf4493536535d33a8

commit cdf2a0febd8a20ef74e782bdf4493536535d33a8
Author: Tom de Vries <tdevries@suse.de>
Date:   Wed Jan 10 11:27:34 2024 +0100

    [gdb] Fix info checkpoints

    Consider test-case gdb.base/checkpoint.exp.  At some point, it issues an
info
    checkpoints command:
    ...
    (gdb) info checkpoints^M
    * 0 process 30570 (main process) at 0x0^M
      1 process 30573 at 0x4008bb, file checkpoint.c, line 49^M
      2 process 30574 at 0x4008bb, file checkpoint.c, line 49^M
      3 process 30575 at 0x4008bb, file checkpoint.c, line 49^M
      4 process 30576 at 0x4008bb, file checkpoint.c, line 49^M
      5 process 30577 at 0x4008bb, file checkpoint.c, line 49^M
      6 process 30578 at 0x4008bb, file checkpoint.c, line 49^M
      7 process 30579 at 0x4008bb, file checkpoint.c, line 49^M
      8 process 30580 at 0x4008bb, file checkpoint.c, line 49^M
      9 process 30582 at 0x4008bb, file checkpoint.c, line 49^M
      10 process 30583 at 0x4008bb, file checkpoint.c, line 49^M
    ...

    According to the docs, each of these (0-10) is a checkpoint.

    But the pc address (as well as the file name and line number) is missing
for
    checkpoint 0.

    Fix this by sampling the pc value for the current process in
    info_checkpoints_command, such that we have instead:
    ...
    * 0 process 30570 (main process) at 0x4008bb, file checkpoint.c, line 49^M
    ...

    Tested on x86_64-linux.

    Approved-By: Kevin Buettner <kevinb@redhat.com>

    PR gdb/31211
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31211

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2024-01-10 10:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-04 14:40 [Bug gdb/31211] New: " vries at gcc dot gnu.org
2024-01-04 14:48 ` [Bug gdb/31211] " vries at gcc dot gnu.org
2024-01-08 15:26 ` vries at gcc dot gnu.org
2024-01-10 10:27 ` cvs-commit at gcc dot gnu.org [this message]
2024-01-10 10:27 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31211-4717-lqP1AzE7cG@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).