public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug exp/31231] [gdb, ppc64le] frame.c:2088: internal-error: get_next_frame_sentinel_okay: Assertion `!is_sentinel_frame_id (this_frame->this_id.value)' failed.
Date: Thu, 11 Jan 2024 18:12:10 +0000	[thread overview]
Message-ID: <bug-31231-4717-mSJlZmBHD8@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31231-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=31231

--- Comment #5 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Simon Marchi <simark@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=47ff07a6c283a39fa3b8c92d823c8851678dfc0f

commit 47ff07a6c283a39fa3b8c92d823c8851678dfc0f
Author: Simon Marchi <simon.marchi@efficios.com>
Date:   Thu Jan 11 11:41:04 2024 -0500

    gdb: fix frame passed to gdbarch_value_to_register in value_assign

    Commit 78f2fd84e83 ("gdb: remove VALUE_REGNUM, add value::regnum")
    introduced an unexpected change in value_assign.  It replaced
    `get_prev_frame_always (next_frame)` with `next_frame`in the call to
    gdbarch_value_to_register.

    This is the result of a merge error, since I previously had a patch to
    change gdbarch_value_to_register to take the next frame, and later
    decided to drop it.  Revert that change.

    Add a test based on the DWARF assembler to expose the problem and test
    the fix.  I also tested on ppc64le to make sure the problem reported in
    PR 31231 was fixed.

    Change-Id: Ib8b851287ac27a4b2e386f7b680cf65865e6aee6
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31231

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2024-01-11 18:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-11 10:29 [Bug exp/31231] New: " vries at gcc dot gnu.org
2024-01-11 10:44 ` [Bug exp/31231] " vries at gcc dot gnu.org
2024-01-11 10:52 ` vries at gcc dot gnu.org
2024-01-11 16:35 ` simark at simark dot ca
2024-01-11 16:51 ` simark at simark dot ca
2024-01-11 18:12 ` cvs-commit at gcc dot gnu.org [this message]
2024-01-11 18:12 ` simark at simark dot ca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31231-4717-mSJlZmBHD8@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).