public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug dap/31263] [gdb] ThreadSanitizer: data race extension.c:755 in set_active_ext_lang(extension_language_defn const*) Date: Wed, 28 Feb 2024 16:13:27 +0000 [thread overview] Message-ID: <bug-31263-4717-EOWVlmjtpP@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-31263-4717@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=31263 --- Comment #5 from Sourceware Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Tom Tromey <tromey@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8bb8f8346729c35433c961f7f1ed3a801776a362 commit 8bb8f8346729c35433c961f7f1ed3a801776a362 Author: Tom Tromey <tromey@adacore.com> Date: Fri Feb 23 08:59:40 2024 -0700 Fix gdb.interrupt race gdb.interrupt was introduced to implement DAP request cancellation. However, because it can be run from another thread, and because I didn't look deeply enough at the implementation, it turns out to be racy. The fix here is to lock accesses to certain globals in extension.c. Note that this won't work in the case where configure detects that the C++ compiler doesn't provide thread support. This version of the patch disables DAP entirely in this situation. Regression tested on x86-64 Fedora 38. I also ran gdb.dap/pause.exp in a thread-sanitizer build tree to make sure the reported race is gone. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31263 -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2024-02-28 16:13 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-18 9:37 [Bug gdb/31263] New: " vries at gcc dot gnu.org 2024-01-18 9:41 ` [Bug gdb/31263] " vries at gcc dot gnu.org 2024-01-22 14:52 ` [Bug dap/31263] " vries at gcc dot gnu.org 2024-01-22 20:32 ` tromey at sourceware dot org 2024-02-12 18:58 ` tromey at sourceware dot org 2024-02-23 15:22 ` tromey at sourceware dot org 2024-02-23 16:21 ` tromey at sourceware dot org 2024-02-28 16:13 ` cvs-commit at gcc dot gnu.org [this message] 2024-02-28 16:14 ` tromey at sourceware dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-31263-4717-EOWVlmjtpP@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).