[Bug gdb/31264] [gdb] ThreadSanitizer: data race format.c:132 in bfd_preserve_save

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31264

--- Comment #12 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=bacc61fd3e6fd61a59fb59bcc657be17a381520d

commit bacc61fd3e6fd61a59fb59bcc657be17a381520d
Author: Tom Tromey <tom@tromey.com>
Date:   Mon Feb 12 18:06:56 2024 -0700

    Thread-safety improvements for bfd_check_format_matches

    A gdb bug found that bfd_check_format_matches has some data races when
    called from multiple threads.

    In particular, it changes the BFD error handler, which is a global.
    It also has a local static variable ("in_check_format") that is used
    for recursion detection.  And, finally, it may emit warnings to the
    per-xvec warning array, which is a global.

    This patch removes all the races here.

    The first part of patch is to change _bfd_error_handler to directly
    handle the needs of bfd_check_format_matches.  This way, the error
    handler does not need to be changed.

    This change lets us use the new per-thread global
    (error_handler_messages, replacing error_handler_bfd) to also remove
    the need for in_check_format -- a single variable suffices.

    Finally, the global per-xvec array is replaced with a new type that
    holds the error messages.  The outermost such type is stack-allocated
    in bfd_check_format_matches.

    I tested this using the binutils test suite.  I also built gdb with
    thread sanitizer and ran the test case that was noted as failing.
    Finally, Alan sent me the test file that caused the addition of the
    xvec warning code in the first place, and I confirmed that "nm-new"
    has the same behavior on this file both before and after this patch.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31264
    Co-Authored-By: Alan Modra <amodra@gmail.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.